Skip to content

Contrib astropy#2724

Merged
boegel merged 4 commits intoeasybuilders:developfrom
tloizou:contrib_astropy
Mar 16, 2016
Merged

Contrib astropy#2724
boegel merged 4 commits intoeasybuilders:developfrom
tloizou:contrib_astropy

Conversation

@tloizou
Copy link
Copy Markdown
Contributor

@tloizou tloizou commented Mar 16, 2016

No description provided.

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Mar 16, 2016

Automatic reply from Jenkins: Can I test this?

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 16, 2016

Jenkins: ok to test

@boegel boegel added this to the v2.8.0 milestone Mar 16, 2016
@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Mar 16, 2016

Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7136/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@tloizou tloizou mentioned this pull request Mar 16, 2016
Merged
@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 16, 2016

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2159.delcatty.os - Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/da8f28226b42e16a6111 for a full test report.

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Mar 16, 2016

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7140/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

boegel
boegel reviewed Mar 16, 2016
View reviewed changes
Comment thread easybuild/easyconfigs/s/setuptools/setuptools-18.4-goolf-1.4.10-Python-2.7.3.eb Outdated
sanity_check_paths = {
'files': ["bin/easy_install", "%s-%s-py%s.egg" % (pylibdir, version, py_short_ver)],
'dirs': []
}
Copy link
Copy Markdown
Member

@boegel boegel Mar 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tloizou please fix indent here?

sanity_check_paths = {
    'files': ["bin/easy_install", "%s-%s-py%s.egg" % (pylibdir, version, py_short_ver)],
    'dirs': [],
}

Copy link
Copy Markdown
Contributor Author

@tloizou tloizou Mar 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel: Indent fixed!

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Mar 16, 2016

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7145/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 16, 2016

Going in, thanks @tloizou!

boegel added a commit that referenced this pull request Mar 16, 2016
@boegel
Merge pull request #2724 from tloizou/contrib_astropy
2666f71 
Contrib astropy
@boegel boegel merged commit 2666f71 into easybuilders:develop Mar 16, 2016
@boegel boegel mentioned this pull request Mar 16, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@tloizou @hpcugentbot @boegel