add CPPFLAGS='-fgnu89-inline' to configopts for M4 v1.4.17 w/ GCCcore/4.9.3#2774
Conversation
|
Automatic reply from Jenkins: Can I test this? |
|
Test report by @boegel |
|
Test report by @boegel |
|
Jenkins: ok to test |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7224/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
This looks OK, and it doesn't seem to break anything, but it would be nice to at least figure out why this works (so we can add a comment in the easyconfig to explain why it's required). @wpoely86 Can you take a quick look? |
|
It's a bit weird that this still is needed but looks harmless to me. |
|
@wpoely86 It fixes the build on CentOS5, see also https://bugs.gentoo.org/show_bug.cgi?id=289757 |
This doesn't help me a lot in explaining why it fixes the problem, but it does suggest it's harmless to include it. I'll merge this and #2779 after testing, and then apply this change to all the M4 easyconfigs... |
|
Going in, thanks @SimonPinches! PR to sync up all M4 1.4.17 easyconfigs is at #2816 |
(created using
eb --new-pr)Fix for this in #529