Skip to content

add CPPFLAGS='-fgnu89-inline' to configopts for M4 v1.4.17 w/ GCCcore/4.9.3#2774

Merged
boegel merged 1 commit intoeasybuilders:developfrom
SimonPinches:20160324171846_new_pr_M41417
Mar 31, 2016
Merged

add CPPFLAGS='-fgnu89-inline' to configopts for M4 v1.4.17 w/ GCCcore/4.9.3#2774
boegel merged 1 commit intoeasybuilders:developfrom
SimonPinches:20160324171846_new_pr_M41417

Conversation

@SimonPinches
Copy link
Copy Markdown
Contributor

(created using eb --new-pr)

Fix for this in #529

@hpcugentbot
Copy link
Copy Markdown

Automatic reply from Jenkins: Can I test this?

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 24, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
gligar03.gligar.os - Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/6c16a2116650b4326c56 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 24, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2636.swalot.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/5f90390b6ff39297272b for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 24, 2016

Jenkins: ok to test

@boegel boegel added this to the v2.8.0 milestone Mar 24, 2016
@hpcugentbot
Copy link
Copy Markdown

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7224/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 25, 2016

This looks OK, and it doesn't seem to break anything, but it would be nice to at least figure out why this works (so we can add a comment in the easyconfig to explain why it's required).

@wpoely86 Can you take a quick look?

@wpoely86
Copy link
Copy Markdown
Member

It's a bit weird that this still is needed but looks harmless to me.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 25, 2016

@wpoely86 It fixes the build on CentOS5, see also https://bugs.gentoo.org/show_bug.cgi?id=289757

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 25, 2016

The option -fgnu89-inline tells GCC to use the traditional GNU semantics for "inline" functions
when in C99 mode.
This option is accepted and ignored by GCC versions 4.1.3 up to but not including 4.3.
In GCC versions 4.3 and later it changes the behavior of GCC in C99 mode.
Using this option is roughly equivalent to adding the "gnu_inline" function attribute to all inline functions.

This doesn't help me a lot in explaining why it fixes the problem, but it does suggest it's harmless to include it.

I'll merge this and #2779 after testing, and then apply this change to all the M4 easyconfigs...

@boegel boegel changed the title {devel}[GCCcore/4.9.3] M4 v1.4.17 add CPPFLAGS='-fgnu89-inline' to configopts for M4 v1.4.17 w/ GCCcore/4.9.3 Mar 31, 2016
@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 31, 2016

Going in, thanks @SimonPinches!

PR to sync up all M4 1.4.17 easyconfigs is at #2816

@boegel boegel merged commit ca9da9f into easybuilders:develop Mar 31, 2016
@SimonPinches SimonPinches deleted the 20160324171846_new_pr_M41417 branch April 12, 2016 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants