{lib}[foss/2016a] Blitz++ v0.10#2784
Conversation
|
Automatic reply from Jenkins: Can I test this? |
|
Jenkins: ok to test |
|
|
||
| sources = ['blitz-%(version)s.tar.gz'] | ||
| source_urls = ['https://sourceforge.net/projects/blitz/files/blitz/%(name)s %(version)s', | ||
| 'download'] |
There was a problem hiding this comment.
This is/looks wrong... is there really supposed to be a space in between name and version? Should it be %(name)s/%(version)s?
Also, you need to wrap this in a tuple (...), otherwise you have a list of two candidate source URLs, rather than one where /download is being glued at the end:
source_urls = [('https://sourceforge.net/projects/blitz/files/blitz/%(name)s/%(version)s', 'download')]
You can update this PR after fixing remarks by just using eb --update-pr 2784 Blitz++-0.10-foss-2016a.eb, after editing Blitz++-0.10-foss-2016a.eb to fix the remarks.
There was a problem hiding this comment.
I agree it looks wrong but the space is really there and is needed. I've fixed the problems highlighted and updated the PR. (I also added the easybuild file for goolf-1.5.16 but maybe this should have been a separate PR?)
There was a problem hiding this comment.
@SimonPinches I'm not seeing the easyconfig for goolf-1.5.16 in here?
Also, I stand to my point that this looks wrong.
What you have here now is that you have two separate download URLs listed: https://sourceforge.net/projects/blitz/files/blitz/%(name)s %(version)s and download.
The latter is obviously wrong.
What you're after is https://sourceforge.net/projects/blitz/files/blitz/%(name)s %(version)s/<tarball>/download,
which can be achieved by specifying a list with a single 2-element tuple, i.e.:
source_urls = [('https://sourceforge.net/projects/blitz/files/blitz/%(name)s/%(version)s', 'download')]This tells EasyBuild to grab the 1st element of the tuple, glue the tarball name after it, and then glue the 2nd part of the tuple (download) after that...
There was a problem hiding this comment.
On 2nd thought, it looks like your reply may apply some other remark from another PR? There's no space involved at all here?
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7231/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
…0.10-goolf-1.5.16.eb
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7363/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Test report by @boegel |
|
lgtm |
|
Test report by @boegel |
|
Going in, thanks @SimonPinches! |
(created using
eb --new-pr)