Skip to content

{bio}[intel/2016a] NGS v1.2.3#2803

Merged
boegel merged 1 commit intoeasybuilders:developfrom
boegel:20160330164702_new_pr_NGS123
Mar 31, 2016
Merged

{bio}[intel/2016a] NGS v1.2.3#2803
boegel merged 1 commit intoeasybuilders:developfrom
boegel:20160330164702_new_pr_NGS123

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Mar 30, 2016

(created using eb --new-pr)

@boegel boegel added this to the v2.8.0 milestone Mar 30, 2016
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 30, 2016

@rjeschmi please review?

@hpcugentbot
Copy link
Copy Markdown

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7249/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@rjeschmi
Copy link
Copy Markdown
Contributor

Test report by @rjeschmi
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
crick - Linux centos 6.6, AMD Opteron(tm) Processor 6380, Python 2.7.8
See https://gist.github.com/d51ca56cd542a7ba10634a1fa7a2acf4 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 31, 2016

@rjeschmi Thanks for testing; can you give this a visual review too?

@rjeschmi
Copy link
Copy Markdown
Contributor

Looks good. Are you going to do the Python bindings as well? I don't need them, but might be good for completeness.

@rjeschmi
Copy link
Copy Markdown
Contributor

Also should there be a standard header so we know the maintainer?

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 31, 2016

@rjeschmi The Python bindings are separate, see #2810; I needed to dance around the chicken-egg situation with NGS and ncbi-vdb...

We can discuss a standard header, maybe open a separate issue on that.
I wouldn't track this in each easyconfig file though, maybe in a separate file per software package?

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 31, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2717.swalot.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/2d5ae9f00b3b6475ac0ddf8bd3d08559 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 31, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2140.delcatty.os - Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/ccb127f565e0a5631357802c966d36ac for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 31, 2016

Going in, thanks for the review @rjeschmi!

@boegel boegel merged commit 225bad8 into easybuilders:develop Mar 31, 2016
@boegel boegel deleted the 20160330164702_new_pr_NGS123 branch March 31, 2016 12:38
@rjeschmi
Copy link
Copy Markdown
Contributor

Test report by @rjeschmi
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in this PR)
maraba - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2630 v3 @ 2.40GHz, Python 2.7.11
See https://gist.github.com/810e8f14c883c783adc8d7e1ce37c201 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants