Skip to content

add easyconfig for FLAC audio codec#2824

Merged
boegel merged 4 commits intoeasybuilders:developfrom
stanford-rc:develop_flac
Apr 4, 2016
Merged

add easyconfig for FLAC audio codec#2824
boegel merged 4 commits intoeasybuilders:developfrom
stanford-rc:develop_flac

Conversation

@thiell
Copy link
Copy Markdown
Contributor

@thiell thiell commented Apr 3, 2016

No description provided.

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Apr 3, 2016

Automatic reply from Jenkins: Can I test this?

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 3, 2016

Jenkins: ok to test

@boegel boegel added this to the v2.8.0 milestone Apr 3, 2016
@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 3, 2016

Test report by @boegel
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in this PR)
node2159.delcatty.os - Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/ee9301cd43e9e3255986d07594dd7e60 for a full test report.

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Apr 3, 2016

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7315/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 3, 2016

@thiell Did this work for you? I'm running into weird issues like:

/tmp/eb-IhRheg/ccXUaEMS.s: Assembler messages:                                                                                                                                 
/tmp/eb-IhRheg/ccXUaEMS.s:62: Error: suffix or operands invalid for `vpmovzxdq'                                                                                                
/tmp/eb-IhRheg/ccXUaEMS.s:85: Error: suffix or operands invalid for `vpmovzxdq'                                                                                                
/tmp/eb-IhRheg/ccXUaEMS.s:86: Error: suffix or operands invalid for `vpaddq'

boegel
boegel reviewed Apr 3, 2016
View reviewed changes
Comment thread easybuild/easyconfigs/f/FLAC/FLAC-1.3.1-foss-2015a.eb Outdated
source_urls = ['http://downloads.xiph.org/releases/flac/']

sanity_check_paths = {
'files': ['bin/flac', 'include/FLAC/all.h', 'lib/libFLAC.so'],
Copy link
Copy Markdown
Member

@boegel boegel Apr 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use SHLIB_EXT rather than hardcoding .so:

    'files': ['bin/flac', 'include/FLAC/all.h', 'lib/libFLAC.%s' % SHLIB_EXT],

@thiell thiell mentioned this pull request Apr 3, 2016
Merged
@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 3, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2702.swalot.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/4ee312efd342bc12c36842134fe7e451 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 3, 2016

@thiell Hmm, the installation does work on CentOS7/Haswell, but not on SL6/Sandy Bridge?

@thiell
Copy link
Copy Markdown
Contributor Author

thiell commented Apr 3, 2016

Grr. :) Looks like this error occurs when using a recent GCC [1]. I'm using a modified foss-2015a including binutils-2.25 (like foss-2015b), that's why I didn't catch that. I'm not sure what to do. It's not a strong dependency for SoX (my main goal for Torch) so I could just drop the FLAC dep there...

[1] http://trac.netlabs.org/rpm/ticket/165#ticket

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Apr 3, 2016

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7321/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 4, 2016

@thiell just include binutils as a build dependency: https://github.com/stanford-rc/easybuild-easyconfigs/pull/1 (if you merge that PR, it will update this PR; I also enabled running the tests, which takes ~15m)

@thiell
Merge pull request #1 from boegel/develop_flac
d4a9e48 
add binutils as build dep for FLAC, also run tests
@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Apr 4, 2016

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7327/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 4, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2615.swalot.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/502f78231505d6dee969c0697c20b625 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 4, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2159.delcatty.os - Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/1f501d362c2a487657e04b10501c167a for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 4, 2016

Going in, thanks @thiell!

@boegel boegel merged commit 3154d7d into easybuilders:develop Apr 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@thiell @hpcugentbot @boegel