pkg-config include as builddependencies#2827
Conversation
|
Automatic reply from Jenkins: Can I test this? |
|
Jenkins: ok to test |
|
@jrbosch Thank you for your contribution! As @hajgato pointed out, there is another open pull request that partially overlaps with this, see #2743. I'll look into merging that PR first, since there has been quite a bit on cleanup in these X11-related easyconfigs lately by @hajgato, w.r.t. build dependencies, etc. I will get back to this PR once #2743 is merged in; I can help you with syncing up your branch to get this merge-ready afterwards. Please don't hesitate to ping for an update in case you don't hear back. |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7342/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
sync with develop & resolve conflicts
| source_urls = ['http://xorg.freedesktop.org/archive/individual/lib/'] | ||
|
|
||
| builddependencies = [ | ||
| ('pkg-config', '0.29') |
There was a problem hiding this comment.
@jrbosch I managed to introduce a syntax error here, leading to this error:
TypeError: 'tuple' object is not callable
The problem is that there's a comma (,) missing at the end of this line, so please change this to:
('pkg-config', '0.29'),|
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7349/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
Test report by @boegel |
|
Test report by @boegel |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7350/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Good to go, thanks @jrbosch, and congratulations on your first contribution to EasyBuild! Keep them coming! |
If pkg-config is not installed in the system. Some packages returns error in the configure step. To avoid this is necessary include pkg-config as builddependencies