Skip to content

{lib}[foss/2016a] libQGLViewer 2.6.3 (REVIEW)#2923

Merged
boegel merged 4 commits intoeasybuilders:developfrom
jrbosch:libQGLViewer_foss
Apr 28, 2016
Merged

{lib}[foss/2016a] libQGLViewer 2.6.3 (REVIEW)#2923
boegel merged 4 commits intoeasybuilders:developfrom
jrbosch:libQGLViewer_foss

Conversation

@jrbosch
Copy link
Copy Markdown
Contributor

@jrbosch jrbosch commented Apr 20, 2016

libQGLViewer easyconfig for foss
needs easyblock hpcugent/easybuild-easyblocks#890

@hpcugentbot
Copy link
Copy Markdown

Automatic reply from Jenkins: Can I test this?

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 20, 2016

Jenkins: ok to test (tests will fail while easyblock is not merged yet, but fine)


builddependencies = [('Qt', '4.8.7')]

start_dir = '%(builddir)s/libQGLViewer-2.6.3/QGLViewer'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't hardcode the version here please, use %(version)s instead:

start_dir = '%(builddir)s/libQGLViewer-%(version)s/QGLViewer'

@hpcugentbot
Copy link
Copy Markdown

Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7640/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@boegel boegel added this to the v2.8.0 milestone Apr 20, 2016
@jrbosch jrbosch changed the title {lib}[foss/2016a] libQGLViewer 2.6.3 (WIP) {lib}[foss/2016a] libQGLViewer 2.6.3 (REVIEW) Apr 20, 2016
@hpcugentbot
Copy link
Copy Markdown

Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7666/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@jrbosch
Copy link
Copy Markdown
Contributor Author

jrbosch commented Apr 20, 2016

after include libgl as dependency, the problem of not finding GL/glu.h is solved. thanks @boegel

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 28, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2159.delcatty.os - Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/d2a647d04533f914d57bb65d523ab47f for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 28, 2016

tested on top of easybuilders/easybuild-easyblocks#890, works great now

@jrbosch please remove the hardcoded easyblock line, and it's good to go

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 28, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2401.golett.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/c7ae4193f6bb1c92beee4ddee6b718ff for a full test report.

@hpcugentbot
Copy link
Copy Markdown

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7788/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 28, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2159.delcatty.os - Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/f6536de51ad6ae88e3c571b455b5475d for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 28, 2016

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 28, 2016

Going in, thanks @jrbosch!

@boegel boegel merged commit b3264a5 into easybuilders:develop Apr 28, 2016
@jrbosch jrbosch deleted the libQGLViewer_foss branch April 28, 2016 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants