readd MariaDB goolf/goalf easyconfigs removed in #217 + style fixes by boegel · Pull Request #293 · easybuilders/easybuild-easyconfigs

boegel · 2013-05-29T19:30:39Z

GCC compiler toolchains that include a recent binutils (goolf-2.x.y?) are required before this can be merged, see easybuilders/easybuild-framework#644.

rjeschmi · 2015-09-17T13:43:15Z

I think this should be closed, and perhaps consider removing mariadb from EB for now.

binutils should be fine on centos6 and above, but the versions here are very old.

Can we tag things for the merge sprint?

boegel · 2015-09-22T18:28:18Z

@rjeschmi: I can try and look into revamping this by updating the MariaDB version here, and using foss/2015b

(I tagged this for tomorrow's sprint)

wpoely86 · 2015-09-23T10:02:22Z

delete this

wpoely86 · 2015-09-23T10:03:26Z

@boegel you do this or you want a me to patch it?

boegel · 2015-09-23T10:12:51Z

@wpoely86: if you're up for patching it, by all means

please bump the MariaDB version and usefoss/2015b while you're at it

* develop: (2813 commits) fix GMP dep in Python 2.7.10 goolf/1.4.10 easyconfig fix remark wrt sources fix remark fix/extend sanity check {lang}[goolf/1.4.10] Python 2.7.10 dcw bumped to 1.1.2 and libxml2 python pound deleted bump to 3.7.0 + bump dep versions Adding moduleclass add missing M4 easyconfig add missing 'easyblock' line A minor change in sources minor style fix add missing 'easyblock' lines, fix style issues add missing patch file for ANTLR add more missing easyblock lines add missing 'easyblock' line Minor changes in configopts add missing easyconfig file install qhull.pc via CMake rather than using postinstallcmds collapse two patches into one ...

update MariaDB

boegel · 2015-09-23T10:41:07Z

@wpoely86: no, leave the existing easyconfig, just add a new one for 10.0.21 with foss/2015b

can you look into a test report too?

why? they are old, untested and never merged?

no, you're changing an easyconfig that's now in develop (and which works fine): https://github.com/hpcugent/easybuild-easyconfigs/tree/develop/easybuild/easyconfigs/m/MariaDB

okay, but it's weird. I never moved this file. I don't understand why git thinks it's a rename.

wpoely86 · 2015-09-23T10:57:11Z

Test report by @wpoely86
FAILED
Build succeeded for 2 out of 3 (2 easyconfigs in this PR)
Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/85e48aae94ac4bacacd5 for a full test report.

BSD replacement for libreadline

some more changes

rjeschmi · 2015-09-23T12:26:22Z

why not just drop back to GNU 4.9.3-2.25 for this. It will be helpful for other toolchains, like PGI.

@wpoely86: remove this easyconfig, serves no purpose anymore?

rjeschmi · 2015-09-23T12:26:56Z

Also here, I prefer dropping down to GNU, thoughts?

+1, makes sense to me

@wpoely86: remove this easyconfig, serves no purpose anymore?

another update

wpoely86 · 2015-09-23T15:05:53Z

Test report by @wpoely86
FAILED
Build succeeded for 7 out of 8 (6 easyconfigs in this PR)
Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/d704ac0c280484078ad8 for a full test report.

Mysql

wpoely86 · 2015-09-23T15:42:33Z

Test report by @wpoely86
SUCCESS
Build succeeded for 5 out of 5 (1 easyconfigs in this PR)
Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/97e855f83cd4e67a95ba for a full test report.

wpoely86 · 2015-09-23T18:46:39Z

lgtm
@rjeschmi @boegel please re-review.

boegel · 2015-09-23T18:47:10Z

Jenkins: test this please

boegel · 2015-09-23T18:48:05Z

Jenkins: ok to test

boegel · 2015-09-23T18:52:07Z

@wpoely86: remove this easyconfig, serves no purpose anymore?

Can you do that yourself? It's your branch 😉

ah, yes, forgot about that part ;)

boegel · 2015-09-25T13:34:05Z

specify why you do this? what's the benefit?

Policy. We want EB controlled versions?

hpcugentbot · 2015-09-25T14:11:40Z

Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4541/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

wpoely86 · 2015-09-25T14:13:20Z

@boegel you forgot the bison-foss easyconfig

hpcugentbot · 2015-09-25T14:30:28Z

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4543/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

boegel · 2015-09-25T14:33:45Z

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
Linux centos linux 7.1.1503, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/d85cd2735da143d39f50 for a full test report.

boegel · 2015-09-25T14:33:46Z

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/aa0bf74b09d344b4703b for a full test report.

boegel · 2015-09-25T14:35:41Z

Hooray! \o/

Oldest PR we have now, ready to go, thanks for the efforts on this @wpoely86, and @rjeschmi for the reviewing.

readd MariaDB goolf/goalf easyconfigs removed in #217 + style fixes

boegel mentioned this pull request Jul 3, 2013

Perl + graphviz + cairo + pango + gnuplot + harfbuzz + libffi + pixman #330

Closed

readd MariaDB goolf/goalf easyconfigs removed in easybuilders#217

39d8323

boegel modified the milestones: v1.x, 2.x Jun 24, 2015

boegel added this to the merge sprint 2.0 milestone Sep 22, 2015

wpoely86 reviewed Sep 23, 2015
View reviewed changes

Comment thread easybuild/easyconfigs/m/MariaDB/MariaDB-5.5.29-ictce-4.1.13.eb Outdated

Copy link
Copy Markdown

Member

wpoely86 Sep 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this

wpoely86 and others added 5 commits September 23, 2015 12:38

Added CMake for foss-2015b

5a906ca

Added up to date MariaDB for foss/2015b

b3324ad

Removed old MariaDB easyconfigs (untested)

63cd42d

Merge pull request #9 from wpoely86/mysql

8e500cc

update MariaDB

wpoely86 mentioned this pull request Sep 23, 2015

update MariaDB boegel/easybuild-easyconfigs#9

Merged

boegel reviewed Sep 23, 2015
View reviewed changes

wpoely86 and others added 6 commits September 23, 2015 13:16

Added Bison for foss/2015b

7da2065

Added source_url to MariaDB

997f04c

Restore MariaDB-5.5.29-ictce-4.1.13.eb

61e2271

Added libedit

e6fbbe0

BSD replacement for libreadline

Mariadb: use libedit

c9eac96

Merge pull request #10 from wpoely86/mysql

3d31539

some more changes

rjeschmi reviewed Sep 23, 2015
View reviewed changes

wpoely86 and others added 4 commits September 23, 2015 14:37

Fix typos in MariaDB

2125bef

Move MariaDB to GNU toolchain

0c1e7d9

Merge pull request #11 from wpoely86/mysql

3c4c1da

another update

Extend dependencies of MariaDB

090abe2

wpoely86 and others added 2 commits September 23, 2015 17:10

Do not use ld.gold for MariaDB

29a60df

Merge pull request #12 from wpoely86/mysql

ebe4e3c

Mysql

boegel reviewed Sep 23, 2015
View reviewed changes

boegel mentioned this pull request Sep 25, 2015

{data}[intel/2015b] DBD-mysql 4.032 (REVIEW) #1992

Merged

boegel reviewed Sep 25, 2015
View reviewed changes

boegel added 2 commits September 25, 2015 15:56

Merge branch 'develop' into mysql

880475a

remove unused easyconfigs

a5bf540

remove unused Bison easyconfig

ce1fa5a

boegel added a commit that referenced this pull request Sep 25, 2015

Merge pull request #293 from boegel/mysql

93eced7

readd MariaDB goolf/goalf easyconfigs removed in #217 + style fixes

boegel merged commit 93eced7 into easybuilders:develop Sep 25, 2015

boegel deleted the mysql branch September 25, 2015 14:35

Conversation

boegel commented May 29, 2013

Uh oh!

rjeschmi commented Sep 17, 2015

Uh oh!

boegel commented Sep 22, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wpoely86 commented Sep 23, 2015

Uh oh!

boegel commented Sep 23, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wpoely86 commented Sep 23, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wpoely86 commented Sep 23, 2015

Uh oh!

wpoely86 commented Sep 23, 2015

Uh oh!

wpoely86 commented Sep 23, 2015

Uh oh!

boegel commented Sep 23, 2015

Uh oh!

boegel commented Sep 23, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hpcugentbot commented Sep 25, 2015

Uh oh!

wpoely86 commented Sep 25, 2015

Uh oh!

hpcugentbot commented Sep 25, 2015

Uh oh!

boegel commented Sep 25, 2015

Uh oh!

boegel commented Sep 25, 2015

Uh oh!

boegel commented Sep 25, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants