Skip to content

[phys]{intel/2016.02-GCC-4.9} VASP 5.4.1#2950

Merged
boegel merged 4 commits intoeasybuilders:developfrom
migueldiascosta:vasp-5.4.1-intel
May 14, 2016
Merged

[phys]{intel/2016.02-GCC-4.9} VASP 5.4.1#2950
boegel merged 4 commits intoeasybuilders:developfrom
migueldiascosta:vasp-5.4.1-intel

Conversation

@migueldiascosta
Copy link
Copy Markdown
Member

Not sure if you're interested in this one (if not, just go ahead and reject the pull request).

On one hand, it's proprietary, so you can only test it if you have access to the package and put it the sources folder (but there are other cases like this in the repository).

On the other hand, again, I couldn't get completely away from some nasty overrides.

@hpcugentbot
Copy link
Copy Markdown

Automatic reply from Jenkins: Can I test this?

@boegel boegel added this to the v2.8.0 milestone Apr 26, 2016
@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 26, 2016

Jenkins: ok to test


sources = [SOURCELOWER_TAR_GZ]

prebuildopts = 'cp arch/makefile.include.linux_intel ./makefile.include; '
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use && rather than ; to glue things together

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 26, 2016

@migueldiascosta although this concerns licensed software, it's still useful for people who have access to it

toolchain = {'name': 'intel', 'version': '2016.02-GCC-4.9'}
toolchainopts = {'usempi': True}

sources = [SOURCELOWER_TAR_GZ]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe include a comment explaining why we don't auto-download this, including a URL with more information on getting access to the sources?

@hpcugentbot
Copy link
Copy Markdown

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7737/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Copy Markdown

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7745/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.


prebuildopts = 'cp arch/makefile.include.linux_intel ./makefile.include && '

buildopts = 'all LIBS="lib" BLACS="$LIBBLACS" '
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the LIBS='lib' correct? now I'm lost... :)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is, but I suppose it's better to use unset LIBS in case what's in the makefile changes

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, I think so

@hpcugentbot
Copy link
Copy Markdown

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7761/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 14, 2016

Going in, thanks @migueldiascosta!

@boegel boegel merged commit 90dcf35 into easybuilders:develop May 14, 2016
@migueldiascosta migueldiascosta deleted the vasp-5.4.1-intel branch May 16, 2016 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants