Skip to content

add xproto build dependency for makedepend v1.0.5 foss/2016a#2982

Merged
boegel merged 5 commits intoeasybuilders:developfrom
SimonPinches:20160430152518_new_pr_makedepend105
May 2, 2016
Merged

add xproto build dependency for makedepend v1.0.5 foss/2016a#2982
boegel merged 5 commits intoeasybuilders:developfrom
SimonPinches:20160430152518_new_pr_makedepend105

Conversation

@SimonPinches
Copy link
Copy Markdown
Contributor

@SimonPinches SimonPinches commented Apr 30, 2016 •
edited
Loading

(created using eb --new-pr)

I needed to add an xproto build dependency to get this to work since it requires xproto >= 7.0.17 and this wasn't met on our system.

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Apr 30, 2016

Automatic reply from Jenkins: Can I test this?

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 30, 2016

Jenkins: ok to test

@boegel boegel added this to the v2.8.0 milestone Apr 30, 2016
boegel
boegel reviewed Apr 30, 2016
View reviewed changes
Comment thread easybuild/easyconfigs/m/makedepend/makedepend-1.0.5-foss-2016a.eb Outdated

sources = [SOURCE_TAR_GZ]
source_urls = [XORG_UTIL_SOURCE]
source_urls = ['http://xorg.freedesktop.org/releases/individual/util']
Copy link
Copy Markdown
Member

@boegel boegel Apr 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonPinches what's wrong with using XORG_UTIL_SOURCE?

Copy link
Copy Markdown
Contributor Author

@SimonPinches SimonPinches May 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just started by using one of the other makedepend eb config files as a template and this is what was contained in there...

@boegel boegel changed the title {devel}[foss/2016a] makedepend v1.0.5 add xproto build dependency for makedepend Apr 30, 2016
@boegel boegel changed the title add xproto build dependency for makedepend add xproto build dependency for makedepend v1.0.5 foss/2016a Apr 30, 2016
@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 30, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
gligar03.gligar.os - Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/43a8cd99ba0872ea9286171cacd2336b for a full test report.

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented Apr 30, 2016

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7825/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented May 1, 2016

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7832/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented May 1, 2016

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7833/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel boegel mentioned this pull request May 1, 2016
Merged
@boegel
Copy link
Copy Markdown
Member

boegel commented May 1, 2016

@SimonPinches SimonPinches#5 makes this change consistent across the makedepend 1.0.5 easyconfigs

@SimonPinches
Merge pull request #5 from boegel/20160430152518_new_pr_makedepend105
78cc1fa 
also add xproto as build dep in other makedepend 1.0.5 easyconfigs
@hpcugentbot
Copy link
Copy Markdown

hpcugentbot commented May 2, 2016

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7852/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 2, 2016

Test report by @boegel
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in this PR)
node2064.delcatty.os - Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/b345ebd9e15a4df83eed4e6e1fe878f0 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 2, 2016

Test report by @boegel
SUCCESS
Build succeeded for 25 out of 25 (6 easyconfigs in this PR)
node2401.golett.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/1eb0a78597eec303e9051d96ff4b5423 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 2, 2016

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented May 2, 2016

Going in, thanks @SimonPinches!

@boegel boegel merged commit fc162fb into easybuilders:develop May 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@SimonPinches @hpcugentbot @boegel