Skip to content

{bio} [foss-2016a] annovar-2016Feb01-foss-2016a-Perl-5.22.1 (REVIEW)#3010

Merged
boegel merged 8 commits intoeasybuilders:developfrom
verdurin:20160507234844_new_pr_annovar2016Feb01
May 16, 2016
Merged

{bio} [foss-2016a] annovar-2016Feb01-foss-2016a-Perl-5.22.1 (REVIEW)#3010
boegel merged 8 commits intoeasybuilders:developfrom
verdurin:20160507234844_new_pr_annovar2016Feb01

Conversation

@verdurin
Copy link
Copy Markdown
Member

@verdurin verdurin commented May 7, 2016

(created using eb --new-pr)
annovar 2016Feb01

@hpcugentbot
Copy link
Copy Markdown

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7909/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.


# Registration required for download
# http://www.openbioinformatics.org/annovar/annovar_download_form.php
sources = ['%(name)s.latest.tar.gz']
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please enforce renaming of the tarball using %(name)s-%(version)s.tar.gz, and include a checksum (I have 2b26e514c54a847bfdcf4ce57e43f95c as MD5 for the version download today)

@hpcugentbot
Copy link
Copy Markdown

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7954/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel boegel added this to the v2.8.0 milestone May 10, 2016
easyblock = 'Tarball'

name = 'annovar'
version = '2016Feb01'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mention how you came to this ($DATE in table_annovar.pl?)

also, I'm more in favour of 20160201, since that'll sort properly

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer that sort of version too, but I took the current version from the website - that's their naming scheme.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, then please include a comment above version explaining where you got it from

@boegel
Copy link
Copy Markdown
Member

boegel commented May 16, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
login103.muk.os - Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/5415fbcb24e9840bedd97dbdc1bb810d for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 16, 2016

Going in, thanks @verdurin!

@boegel boegel merged commit d4dc437 into easybuilders:develop May 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants