clean up dummy bzip2 easyconfig, define buildopts rather than defining $CC and $CFLAGS via os.environ#3036
Conversation
…g and via os.environ
…g $CC and $CFLAGS via os.environ
| os.environ['CFLAGS'] = '-O3 -fPIC' | ||
| buildopts = "CC=gcc CFLAGS='-Wall -Winline -O3 -fPIC -g $(BIGFILES)'" | ||
|
|
||
| # disable building of shared libraries, doesn't work everywhere (e.g. on OS X, where 'gcc' is actually Clang...) |
There was a problem hiding this comment.
sorry, but not working on OS X is not a good enough reason to disable it by default.
There was a problem hiding this comment.
well, it was disabled already (without the enhanced of the bzip2 easyblock)
I prefer being able to install bzip2 without shared libs over not installing it, especially since the shared libraries are rarely needed anyway (you can tell by i) the way they need to be installed, ii) a libbz2.so isn't even installed by default)
There was a problem hiding this comment.
If it doesn't work on any Linux system fine, but only OS X is not good enough.
There was a problem hiding this comment.
So, you want me to patch the Makefile for the .so instead so it works on OS X too?
I'm just avoiding a regression, and the .so's are basically pointless for the dummy installation of bzip2
There was a problem hiding this comment.
how about this gem then?
with_shared_libs = OS_TYPE == 'Linux'|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7979/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Test report by @boegel |
|
Test report by @boegel |
|
Test report by @boegel |
|
Going in, thanks for the review @wpoely86! |
mainly done to avoid the
import os...this requires
easybuilders/easybuild-easyblocks#910(with pescobar/easybuild-easyblocks#5 included)