274 contrib dependencies for life science applications: biodeps#309
274 contrib dependencies for life science applications: biodeps#309boegel merged 15 commits intoeasybuilders:developfrom
Conversation
Signed-off-by: Fotis Georgatos <[email protected]>
Signed-off-by: Fotis Georgatos <[email protected]>
Signed-off-by: Fotis Georgatos <[email protected]>
There was a problem hiding this comment.
Why dance around the templating provided by EasyBuild like this?
There are two better alternatives for this:
- use the
namelowertemplate, i.e.:
source_urls = [('http://sourceforge.net/projects/%(namelower)s/files/%(namelower)s/%(version)s', 'download')]- use the
SOURCEFORGE_SOURCEconstant:
source_urls = [SOURCEFORGE_SOURCE]Please use the latter, which is equivalent to http://download.sourceforge.net/%(namelower)s (see eb --avail-easyconfig-templates), in all Boost easyconfigs. I have a branch ready that does just that, let me know if you'll clean this up or I should open the PR (which will cause conflicts with what you currently have).
There was a problem hiding this comment.
sorry for the delay, I fixed it as per 2nd suggestion; I'm fun of the motto:
less chars to type => less human in the process => more robust
Signed-off-by: Fotis Georgatos <[email protected]>
There was a problem hiding this comment.
Please use SOURCEFORGE_SOURCE here too, and in all other Boost easyconfigs.
There was a problem hiding this comment.
OK, done... please review
Signed-off-by: Fotis Georgatos <[email protected]>
There was a problem hiding this comment.
Use a different construction here, to avoid unintentionally breaking the match with versionsuffix and dep:
name = 'Mothur'
version = '1.30.2'
biodeps = 'biodeps'
biodeps_ver = '1.6'
versionsuffix = '-%s-%s' % (biodeps, biodeps_ver)
dependencies = [
(biodeps, biodeps_ver),
('gzip', '1.5'),
]Likewise for the other easyconfigs that use biodeps, of course.
Signed-off-by: Fotis Georgatos <[email protected]>
Signed-off-by: Fotis Georgatos <[email protected]>
Signed-off-by: Fotis Georgatos <[email protected]>
|
OK, pushed a new patchset (tested it, seems to work for the biodeps business fine and has examples for both cases) |
fix Boost source URL, in alignment with easybuilders#309
|
merged in Ken's diffs; thanks for the contrib! |
There was a problem hiding this comment.
Homepage doesn't make sense... Better use (none), like we do for e.g. goolf.
Or maybe better, refer to the relevant HPCBIOS page?
There was a problem hiding this comment.
OK, good catch, thanks for spotting... fixed, please re-re-re-re-review!
This PR does a number of things:
biodeps(common life science applications dependencies) for goolf/1.4.10 (gnu) & ictce/5.3.0 (intel)