{bio}[goolf/1.7.20] fastQValidator v0.1.1a-20151214#3192
Conversation
|
Test report by @pescobar |
|
|
||
| sources = [ | ||
| '%s.tar.gz' % fastqvalidator_git_commit, | ||
| '%s.tar.gz' % libstatgen_git_commit |
There was a problem hiding this comment.
because of the way EasyBuild works, there is a non-zero probability
that you may end up hitting a tarball with the same commit id from the other source_url;
for this reason, I'd consider it recommended to provide the tarball hashes, as extra safety... <0.02 cents...
There was a problem hiding this comment.
@pescobar good to go once checksums have been added for the sources
There was a problem hiding this comment.
actually, thinking about this again, it would be a pretty weird coincidence if you could download the same commit from another repo...
so, I'll go ahead and merge this as-is, thanks @pescobar!
|
Test report by @boegel |
|
Test report by @boegel |
|
lgtm |
|
Going in, thanks @pescobar! |
(created using
eb --new-pr)