Skip to content

Contrib dca easyconfig#3219

Merged
boegel merged 21 commits intoeasybuilders:developfrom
gbalduzz:contrib_dca_easyconfig
Jul 7, 2016
Merged

Contrib dca easyconfig#3219
boegel merged 21 commits intoeasybuilders:developfrom
gbalduzz:contrib_dca_easyconfig

Conversation

@gbalduzz
Copy link
Copy Markdown
Contributor

I hope this time I issued the pull request against the correct branch and followed the correct procedure.
Cheers, G.B.

@gbalduzz gbalduzz force-pushed the contrib_dca_easyconfig branch from 331c95f to d68479b Compare June 16, 2016 12:35
@boegel boegel mentioned this pull request Jun 16, 2016
@gppezzi
Copy link
Copy Markdown
Contributor

gppezzi commented Jun 17, 2016

I've issued a PR to @gbalduzz's branch to fix the file name of the DCA easyconfig files.

As for the rest, it looks good.

gbalduzz and others added 4 commits June 20, 2016 09:33
@gbalduzz gbalduzz force-pushed the contrib_dca_easyconfig branch from e6ebb0a to ed0c388 Compare June 22, 2016 12:03
@@ -0,0 +1,20 @@
# Built with EasyBuild version 2.8.1 on 2016-06-16_13-37-02
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove this comment?

@gppezzi
Copy link
Copy Markdown
Contributor

gppezzi commented Jun 29, 2016

Test report by @gppezzi
SUCCESS
Build succeeded for 7 out of 7 (6 easyconfigs in this PR)
daint101 - Linux SLES 11_SP3, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.6
See https://gist.github.com/6e11526bd638805b7a5fb77363627355 for a full test report.

@boegel boegel added this to the v2.9.0 milestone Jul 4, 2016
'dirs': ['include'],
}

patches = [('magma-2.0.0.patch')]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move this up below sources/source_urls

versionsuffix = '-cuda'

homepage = 'http://www.itp.phys.ethz.ch/research/comp/computation.html'
description = """The DCA++ software project is a C++ implementation of the dynamical cluster approximation (DCA) and its DCA+ extension. It aims to solve lattice models of strongly correlated electron systems. This module bundles all the dependencies for the CPU+GPU version."""
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too long, please wrap

@gppezzi
Copy link
Copy Markdown
Contributor

gppezzi commented Jul 4, 2016

Test report by @gppezzi
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in this PR)
daint104 - Linux SLES 11_SP3, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.6
See https://gist.github.com/d17acd81f5d863a3e5dc0699991a3eb0 for a full test report.

@gppezzi
Copy link
Copy Markdown
Contributor

gppezzi commented Jul 4, 2016

@boegel I hope I didn't miss any of your remarks, now it should be good to go

@boegel
Copy link
Copy Markdown
Member

boegel commented Jul 7, 2016

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Jul 7, 2016

Going in, thanks @gbalduzz!

@boegel boegel merged commit 2457be8 into easybuilders:develop Jul 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants