{geo}[foss-2016a] pyGIMLi - Python 3.5.1 (REVIEW)#3403
{geo}[foss-2016a] pyGIMLi - Python 3.5.1 (REVIEW)#3403boegel merged 8 commits intoeasybuilders:developfrom
Conversation
| easyblock = 'PythonPackage' | ||
|
|
||
| name = 'pyplusplus' | ||
| version = '2c6c05b7a7d2' |
There was a problem hiding this comment.
@hajgato wouldn't it be better to use a datestamp as version here (which sorts properly) rather than a commit ID?
|
@boegel Done |
|
Test report by @boegel |
|
@hajgato does this still work for you? |
|
@boegel: The name of install subdir changed, I forget to insert a star into the directory name. Now it should work. |
| preinstallopts += '&& cp -a ../gimli*/python/. %(installdir)s/lib/python%(pyshortver)s/site-packages ' | ||
| preinstallopts += '&& cp -a ../easybuild_obj/lib/. %(installdir)s/lib/ ' | ||
| preinstallopts += '&& mkdir %(installdir)s/bin ' | ||
| preinstallopts += '&& cp ../easybuild_obj/bin/* %(installdir)s/bin ||' |
There was a problem hiding this comment.
@hajgato hmh, the || part is a hack to bypass make install, right?
Maybe we should go for a software-specific easyblock here instead? Or CMakeMakeCp?
There was a problem hiding this comment.
hmmm. Do not remember why I did this. I have to check it. (I am not sure that we habv make install...)
There was a problem hiding this comment.
@boegel: ah I remember. if I use make install then the python libs would not be installed. Alternatively, I can do this:
preinstallopts = 'mkdir -p %(installdir)s/lib/python%(pyshortver)s/site-packages '
preinstallopts += '&& cp -a ../gimli*/python/. %(installdir)s/lib/python%(pyshortver)s/site-packages &&'
There was a problem hiding this comment.
@hajgato I think doing it via installopts (so, after the make install) would be cleaner, no?
Also, doesn't this suggest there's a bug in the Makefile?
There was a problem hiding this comment.
@boegel: changed to installopts. A CMakeMakeCp block could be an idea, but I am not keen to do that. This EB is not sooo complicated.
| installopts = ' && mkdir -p %(installdir)s/lib/python%(pyshortver)s/site-packages ' | ||
| installopts += '&& cp -a ../gimli*/python/. %(installdir)s/lib/python%(pyshortver)s/site-packages ' | ||
| installopts += '&& mkdir %(installdir)s/bin ' | ||
| installopts += '&& cp ../easybuild_obj/bin/* %(installdir)s/bin' |
There was a problem hiding this comment.
@hajgato is this also still needed? not handled by make install?
|
@boegel: Only the lib is installed. I think it is related to the fact that by default only the library built. You have to add to the |
|
@hajgato sure, I was just wondering... I'll retest this, but good to go for me otherwise. |
|
Test report by @boegel |
|
Test report by @boegel |
|
Test report by @boegel |
needs PR
#3398#3393#3392