Skip to content

{bio}[intel/2016b] GRIT v2.0.5#3561

Merged
boegel merged 1 commit intoeasybuilders:developfrom
boegel:20160909172046_new_pr_GRIT205
Sep 9, 2016
Merged

{bio}[intel/2016b] GRIT v2.0.5#3561
boegel merged 1 commit intoeasybuilders:developfrom
boegel:20160909172046_new_pr_GRIT205

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Sep 9, 2016

(created using eb --new-pr)

}),
]

modextrapaths = {'PYTHONPATH': ['lib/python%(pyshortver)s/site-packages']}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a block for this, but shouldn't this happen automatically when the extension is PythonPackage?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

open an issue for this in the easyblocks repo, I'll see if we can make that happen (or why it doesn't happen already)

I think the problem is that we don't want every extension to prepend to $PYTHONPATH, it just needs to be done once...

@wpoely86
Copy link
Copy Markdown
Member

wpoely86 commented Sep 9, 2016

👍

@boegel boegel added this to the v2.9.0 milestone Sep 9, 2016
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 9, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2636.swalot.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/f73515233a4a346d347d69e793782485 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 9, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2047.delcatty.os - Linux SL 6.8, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/0f47a5cf4f64b91ba7df40f5e7ddeb56 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 9, 2016

Thanks for the review @wpoely86!

@boegel boegel merged commit 7c985e5 into easybuilders:develop Sep 9, 2016
@boegel boegel deleted the 20160909172046_new_pr_GRIT205 branch September 9, 2016 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants