Skip to content

Protobuf 3.0.2#3563

Merged
boegel merged 6 commits intoeasybuilders:developfrom
rug-cit-hpc:protobuf302foss2016a
Sep 14, 2016
Merged

Protobuf 3.0.2#3563
boegel merged 6 commits intoeasybuilders:developfrom
rug-cit-hpc:protobuf302foss2016a

Conversation

@FokkeDijkstra
Copy link
Copy Markdown
Contributor

@FokkeDijkstra FokkeDijkstra commented Sep 13, 2016

Google protobuf 3.0.2 including the Python library. Since protobuf includes libraries that can be used by other programs using a dummy toolchain (as done for older protobuf versions) does not seem to be the right approach.
For now I've choosen the foss 2016a toolchain. Since protobuf itself is a low level compiler and library using a GCC toolchain could also be an option for the main protobuf. Please let me know if this approach is better.

@FokkeDijkstra
Version of protobuf using the foss 2016a toolchain. Since
0b6784a 
protobuf includes libraries, compiling it with the compiler from
a toolchain seems better.
@FokkeDijkstra
Python library for Google protobuf, compiled using foss 2016a.
ca92456
@FokkeDijkstra
Version of protobuf using the foss 2016a toolchain. Since
21a129f 
protobuf includes libraries, compiling it with the compiler from
a toolchain seems better.
@FokkeDijkstra
Python library for Google protobuf, compiled using foss 2016a.
e35203c
@boegel boegel added this to the v2.9.0 milestone Sep 13, 2016
boegel
boegel reviewed Sep 13, 2016
View reviewed changes
Comment thread easybuild/easyconfigs/p/protobuf-python/protobuf-python-3.0.2-foss-2016a-Python-2.7.11.eb Outdated
source_urls = ['https://github.com/google/protobuf/archive/v%(version)s']
sources = [SOURCE_TAR_GZ]

versionsuffix = '-Python-%(pyver)s'
Copy link
Copy Markdown
Member

@boegel boegel Sep 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FokkeDijkstra this is overwriting the previous definition for versionsuffix (which is wrong), so move this up and remove the other one?

@FokkeDijkstra
Fixed:
26d4b8d 
- versionsuffix
- removed check for __init__.py in egg directory
- check for site-packages directory instead
- removed check for bin directory as it does not contain important files
@FokkeDijkstra
Merge branch 'protobuf302foss2016a' of github.com:rug-cit-ris/easybui…
569848b 
…ld-easyconfigs into protobuf302foss2016a
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 13, 2016

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2587.golett.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/e3d31362026a6974e9dc443c78614c32 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 13, 2016

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2154.delcatty.os - Linux SL 6.8, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/5fc3e3da1ed0cc720ebe338b4f5b9de3 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 14, 2016

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 14, 2016

Going in, thanks @FokkeDijkstra!

@boegel boegel merged commit 8c19ffa into easybuilders:develop Sep 14, 2016
@FokkeDijkstra FokkeDijkstra deleted the protobuf302foss2016a branch September 14, 2016 07:54
@boegel boegel mentioned this pull request Nov 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.9.0

Development

Successfully merging this pull request may close these issues.

2 participants

@FokkeDijkstra @boegel