Skip to content

{phys}[intel/2016b] Elk v4.0.15#3644

Merged
boegel merged 2 commits intoeasybuilders:developfrom
migueldiascosta:20161005115127_new_pr_Elk4015
Oct 6, 2016
Merged

{phys}[intel/2016b] Elk v4.0.15#3644
boegel merged 2 commits intoeasybuilders:developfrom
migueldiascosta:20161005115127_new_pr_Elk4015

Conversation

@migueldiascosta
Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta commented Oct 5, 2016

(created using eb --new-pr)

migueldiascosta
migueldiascosta commented Oct 5, 2016
View reviewed changes
Comment thread easybuild/easyconfigs/e/Elk/Elk-4.0.15-intel-2016.01.eb
# make.inc file is generated interactively by "setup" command, creating it here
prebuildopts = 'echo "F90_OPTS = $FFLAGS" > make.inc && '
prebuildopts += 'echo "F77_OPTS = $FFLAGS" >> make.inc && '
prebuildopts += 'echo "LIB_LPK = $LIBLAPACK" >> make.inc && '
Copy link
Copy Markdown
Member Author

@migueldiascosta migueldiascosta Oct 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better way?

Copy link
Copy Markdown
Member

@boegel boegel Oct 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fairly OK to me.

The only better/cleaner way I can think of is to create an Elk-specific easyblock to take care of this, but that has other downsides compared to the easyconfig-only approach.

Copy link
Copy Markdown
Member

@boegel boegel Oct 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@migueldiascosta let me know if you're happy with this as-is; with the successful test reports this is good to merge if you ask me

Copy link
Copy Markdown
Member Author

@migueldiascosta migueldiascosta Oct 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel I'm ok if you're ok :)

@migueldiascosta migueldiascosta changed the title {phys}[intel/2016.01] Elk v4.0.15 {phys}[intel/2016b] Elk v4.0.15 Oct 5, 2016
@boegel boegel added this to the 3.0 milestone Oct 6, 2016
@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 6, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2134.delcatty.os - Linux SL 6.8, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/4bf144e2b973f00c0cce73362f4d1aac for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 6, 2016

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in this PR)
node2301.phanpy.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/d36feb1570c449df20d738a7114fa787 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 6, 2016

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 6, 2016

Going in, thanks @migueldiascosta!

@boegel boegel merged commit 87f9d98 into easybuilders:develop Oct 6, 2016
@migueldiascosta migueldiascosta deleted the 20161005115127_new_pr_Elk4015 branch December 1, 2016 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@migueldiascosta @boegel