Skip to content

Eliminate dependency on mpi-mic-rt in ifort.#3793

Merged
boegel merged 3 commits intoeasybuilders:developfrom
bartoldeman:ifort-no-mpi-rt
Nov 15, 2016
Merged

Eliminate dependency on mpi-mic-rt in ifort.#3793
boegel merged 3 commits intoeasybuilders:developfrom
bartoldeman:ifort-no-mpi-rt

Conversation

@bartoldeman
Copy link
Copy Markdown
Contributor

@bartoldeman bartoldeman commented Nov 14, 2016

This dependency causes Intel mpirun/mpiexec to be added to $PATH
when the ifort module is loaded, which is not always desirable,
for instance when OpenMPI is already loaded.

Fixes easybuilders/easybuild-easyblocks#1032.

@bartoldeman
Eliminate dependency on mpi-mic-rt in ifort.
b9ad02d 
This dependency causes Intel mpirun/mpiexec to be added to $PATH
when the ifort module is loaded, which is not always desirable,
for instance when OpenMPI is already loaded.

Fixes easybuilders/easybuild-easyblocks#1032.
@bartoldeman
Copy link
Copy Markdown
Contributor Author

bartoldeman commented Nov 14, 2016

Note: I have tested the patch only on 2017.1, 2017.0 and 2016.2. Does your automatic testing test on the other 2016 varieties?

@boegel boegel added this to the 3.0 milestone Nov 14, 2016
@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 14, 2016

@bartoldeman If I trigger a test report, all touched easyconfigs will be tested.

However, the required patch file ifort_2016_no_mpi_mic_dependency.patch is missing in this PR, can you please include that too?

Also, please also update ifort-2016.0.109-GCC-4.9.3-2.25.eb to use the patch, so we cover all 2016 and 2017 ifort versions?

Does this only apply to ifort, not icc?

@boegel boegel mentioned this pull request Nov 14, 2016
Closed
@bartoldeman
Copy link
Copy Markdown
Contributor Author

bartoldeman commented Nov 15, 2016

my apologies for the missing files. There are there now.

icc is not affected at all.

for ifort I even see mpirt for 2015 versions, in
$EBROOTICC/mpirt/
but this is not picked up in the easyblock (easyblock looks for "mpi", not "mpirt").

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 15, 2016

Test report by @boegel
SUCCESS
Build succeeded for 11 out of 11 (10 easyconfigs in this PR)
node2059.delcatty.os - Linux SL 6.8, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/54239399b29d4db5fac0d0016d560f76 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 15, 2016

Test report by @boegel
SUCCESS
Build succeeded for 10 out of 10 (10 easyconfigs in this PR)
node2407.golett.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/3eb909b87082cac7064c90f0c4eac7de for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 15, 2016

Thanks for the update & info @bartoldeman!

I diffed the contents of the ifort install directory with and without this patch, and it looks as expected.

I see no reason to hold this back further, going in, thanks @bartoldeman!

@boegel boegel merged commit d76e79e into easybuilders:develop Nov 15, 2016
@bartoldeman bartoldeman mentioned this pull request Mar 29, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@bartoldeman @boegel