Skip to content

{bio}[intel/2016b] PhyloBayes-MPI v20161021#3859

Merged
boegel merged 1 commit intoeasybuilders:developfrom
boegel:20161124143331_new_pr_PhyloBayes-MPI20161021
Nov 25, 2016
Merged

{bio}[intel/2016b] PhyloBayes-MPI v20161021#3859
boegel merged 1 commit intoeasybuilders:developfrom
boegel:20161124143331_new_pr_PhyloBayes-MPI20161021

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Nov 24, 2016

(created using eb --new-pr)

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 24, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2119.delcatty.os - Linux SL 6.8, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/7e5a579401d84dd68c2aff7ef8b3df65 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 24, 2016

@wpoely86 please review

@boegel boegel added this to the 3.0.1 milestone Nov 24, 2016
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 24, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2587.golett.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/c8f783964b484f49f815bd87127aab90 for a full test report.

# get rid of included binaries to ensur they're recompiled
prebuildopts = "rm -f data/* &&"

buildopts = 'CC="$MPICXX" CPPFLAGS="$CXXFLAGS -c" LDFLAGS="$CXXFLAGS"'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why overwrite LDFLAGS with CXXFLAGS?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because the Makefile hardcodes -O3, there aren't any flags in there to link with libraries or anything:

$ head -3 sources/Makefile 
CC=mpic++
CPPFLAGS= -w -O3 -c
LDFLAGS= -O3

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 25, 2016

Thanks for the review @wpoely86!

@boegel boegel merged commit 9fa1971 into easybuilders:develop Nov 25, 2016
@boegel boegel deleted the 20161124143331_new_pr_PhyloBayes-MPI20161021 branch November 25, 2016 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants