Skip to content

{bio}[dummy/dummy] findhap v4#3860

Merged
boegel merged 2 commits intoeasybuilders:developfrom
verdurin:20161126130119_new_pr_findhap4
Nov 26, 2016
Merged

{bio}[dummy/dummy] findhap v4#3860
boegel merged 2 commits intoeasybuilders:developfrom
verdurin:20161126130119_new_pr_findhap4

Conversation

@verdurin
Copy link
Copy Markdown
Member

(created using eb --new-pr)

\\$EBROOTFINDHAP/genotypes.txt
\\$EBROOTFINDHAP/chromosome.data
\\$EBROOTFINDHAP/pedigree.file
\\$EBROOTFINDHAP/sequences.readdepth
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@verdurin should we include these 5 files in sanity_check_paths, to avoid spitting out meaningless messages on load?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel It won't run without them, but the ones provided in the zip are just examples. What I've put in the message is really just a usage hint, though people wanting to run it should know already.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, ok, I'm just saying that it's worth making sure these files are actually there when we mention them in a load msg?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, and fixed.

@boegel boegel added this to the 3.0.1 milestone Nov 26, 2016
@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 26, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2679.swalot.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/c6016701ccc616b7a54dc7fb188ffc61 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 26, 2016

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 26, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node1002.muk.os - Linux SL 6.8, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/6bd32217f4d1a748606184aa3922183f for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 26, 2016

Going in, thanks @verdurin!

@boegel boegel merged commit 2c1b66b into easybuilders:develop Nov 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants