Skip to content

{bio} [intel/2016b] taco/0.5.1 (REVIEW)#3882

Merged
boegel merged 2 commits intoeasybuilders:developfrom
wpoely86:taco
Dec 1, 2016
Merged

{bio} [intel/2016b] taco/0.5.1 (REVIEW)#3882
boegel merged 2 commits intoeasybuilders:developfrom
wpoely86:taco

Conversation

@wpoely86
Copy link
Copy Markdown
Member

@wpoely86 wpoely86 commented Dec 1, 2016

No description provided.

@boegel boegel added this to the 3.0.2 milestone Dec 1, 2016
@wpoely86
Copy link
Copy Markdown
Member Author

wpoely86 commented Dec 1, 2016

Test report by @wpoely86
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2400.golett.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/25e31ef7f2ddda74b1d1000c85e072f2 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 1, 2016

lgtm

@wpoely86
Copy link
Copy Markdown
Member Author

wpoely86 commented Dec 1, 2016

Test report by @wpoely86
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2032.delcatty.os - Linux SL 6.8, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/38a3e8b5e8e20cefc3c77f4a39fbc3ba for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 1, 2016

Going in, thanks @wpoely86!

@boegel boegel merged commit e2e2447 into easybuilders:develop Dec 1, 2016
@wpoely86 wpoely86 deleted the taco branch December 1, 2016 13:49
boegel
boegel reviewed Jan 3, 2017
View reviewed changes
Comment thread easybuild/easyconfigs/t/taco/taco-0.5.1-intel-2016b-Python-2.7.12.eb
('Python', '2.7.12'),
]

postinstallcmds = ["mv %(installdir)s/bin/taco_run.py %(installdir)s/bin/taco_run"]
Copy link
Copy Markdown
Member

@boegel boegel Jan 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wpoely86 what made you rename this to taco_run rather than taco, which seems to be the usual main command (see 'Getting started' at https://tacorna.github.io/)?

Copy link
Copy Markdown
Member Author

@wpoely86 wpoely86 Jan 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cause the docs I read where using taco_run.

Copy link
Copy Markdown
Member

@boegel boegel Jan 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you happen to remember which docs?

Copy link
Copy Markdown
Member Author

@wpoely86 wpoely86 Jan 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/tacorna/taco/blob/master/build.sh#L13 where it gets installed as taco_run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0.2

Development

Successfully merging this pull request may close these issues.

2 participants

@wpoely86 @boegel