Skip to content

{base,bio}[dummy/dummy] UCLUST v1.2.22q, USEARCH v5.2.236-6.1.544#3896

Merged
boegel merged 1 commit intoeasybuilders:developfrom
boegel:20161206114028_new_pr_UCLUST1222q
Dec 9, 2016
Merged

{base,bio}[dummy/dummy] UCLUST v1.2.22q, USEARCH v5.2.236-6.1.544#3896
boegel merged 1 commit intoeasybuilders:developfrom
boegel:20161206114028_new_pr_UCLUST1222q

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Dec 6, 2016

(created using eb --new-pr)
fleshed out from #1057, required for QIIME

@boegel boegel added this to the 3.0.2 milestone Dec 6, 2016
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 6, 2016

@verdurin please review

@boegel boegel mentioned this pull request Dec 6, 2016
Merged
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 6, 2016

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2595.golett.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/bc135c7e0c61d2679fc272b4f9451a90 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 6, 2016

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2130.delcatty.os - Linux SL 6.8, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/95e12a256fc4f6615b669f39815dfbf2 for a full test report.

verdurin
verdurin reviewed Dec 8, 2016
View reviewed changes
Copy link
Copy Markdown
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They look okay from a visual review, pity about the need for such careful naming. Will run a test build when I can.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 9, 2016

@verdurin the naming in the combo of 5.x and 6.x is mainly because of using them as a dep for QIIME

I'll go ahead and merge this, since there's little that could go wrong with the actual installation imho.

Don't hesitate to post any issues you may run into with this though...

@boegel boegel merged commit 08a0362 into easybuilders:develop Dec 9, 2016
@boegel boegel deleted the 20161206114028_new_pr_UCLUST1222q branch December 9, 2016 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@verdurin verdurin verdurin left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0.2

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @verdurin