Skip to content

{phys}[intel/2016b] RASPA2 2.0.3 w/Python-2.7.12 (REVIEW)#3903

Merged
boegel merged 2 commits intoeasybuilders:developfrom
hajgato:RASPA2
Dec 8, 2016
Merged

{phys}[intel/2016b] RASPA2 2.0.3 w/Python-2.7.12 (REVIEW)#3903
boegel merged 2 commits intoeasybuilders:developfrom
hajgato:RASPA2

Conversation

@hajgato
Copy link
Copy Markdown
Collaborator

@hajgato hajgato commented Dec 6, 2016

No description provided.

boegel
boegel reviewed Dec 7, 2016
View reviewed changes
Comment thread easybuild/easyconfigs/r/RASPA2/RASPA2-2.0.3-intel-2016b-Python-2.7.12.eb Outdated

sanity_check_paths = {
'files': ['bin/raspa-dir', 'bin/simulate'],
'dirs': ['lib/python%(pyshortver)s/site-packages/%(name)s-%(version)s-py%(pyshortver)s-linux-x86_64.egg']
Copy link
Copy Markdown
Member

@boegel boegel Dec 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hajgato since this .egg directory may also become a (zipped) .egg file under some circumstances, we typically rely on just checking for lib/python%(pyshortver)s/site-packages + the import check that is done by PythonPackage...

Copy link
Copy Markdown
Collaborator Author

@hajgato hajgato Dec 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel corrected.

@boegel boegel added this to the 3.0.2 milestone Dec 7, 2016
@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 7, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2159.delcatty.os - Linux SL 6.8, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/eb916f45768bd0e049637bbdb691bb7b for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 8, 2016

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 8, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2684.swalot.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/fd5f4149a4fc4611f5a4fa1a6c7c1d03 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 8, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2082.delcatty.os - Linux SL 6.8, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/015ec08bafd64f3db7e1bab497606064 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 8, 2016

Going in, thanks @hajgato!

@boegel boegel merged commit a5019ed into easybuilders:develop Dec 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0.2

Development

Successfully merging this pull request may close these issues.

2 participants

@hajgato @boegel