{vis}[intel/2016b] hyperspy v1.1.1#3991
Conversation
|
Test report by @boegel |
verdurin
left a comment
There was a problem hiding this comment.
Please change the homepage and description to be HyperSpy-specific
| version = '1.1.1' | ||
| versionsuffix = '-Python-%(pyver)s' | ||
|
|
||
| homepage = 'http://scikit-learn.org/stable/index.html' |
There was a problem hiding this comment.
Oughtn't you to give the Hyperspy home page, rather than the Scikit-learn one?
| building upon numpy, scipy, and matplotlib. As a machine-learning module, | ||
| it provides versatile tools for data mining and analysis in any field of science and engineering. | ||
| It strives to be simple and efficient, accessible to everybody, and reusable in various contexts.""" | ||
|
|
There was a problem hiding this comment.
Same here - shouldn't this be the HyperSpy description, rather than the scikit-learn one?
There was a problem hiding this comment.
ugh, that's stupid of me, forgot to change this after starting from an existing easyconfig (can you guess which one?)...
This is exactly why we have reviews, thanks @verdurin!
|
Test report by @boegel |
|
Going in, thanks for the review @verdurin! |
(created using
eb --new-pr)