{vis}[dummy/] GroIMP v1.5#3994
Conversation
|
@verdurin please review? |
|
Test report by @boegel |
|
Test report by @boegel |
| description = """Apache Ant is a Java library and command-line tool whose mission is to drive processes described in build files | ||
| as targets and extension points dependent upon each other. The main known usage of Ant is the build of Java applications.""" | ||
|
|
||
| toolchain = {'name': 'dummy', 'version': ''} |
There was a problem hiding this comment.
I thought we had to put dummy in the version field too.
Has that changed now?
There was a problem hiding this comment.
There's a subtle difference between using dummy as a version, or not.
If you use dummy, then the dependences listed will not be loaded at installation time (but the corresponding module load statements will be included in the generated module if the installation worked).
We have plans to get rid of this, see easybuilders/easybuild-framework#1233
There was a problem hiding this comment.
Okay, good to know. I knew there was some subtle difference, that I couldn't remember.
| sources = ['GroIMP-%(version)s-src.zip'] | ||
|
|
||
| dependencies = [ | ||
| ('Java', '1.8.0_112', '', True), |
There was a problem hiding this comment.
What are these two additional fields? I've noticed them in other recent easyconfigs.
A new requirement?
There was a problem hiding this comment.
3rd value is versionsuffix (which is only required to specify the 4th)
4th indicates that this dep is to be resolved using dummy toolchain
In this case, it's stupid though, since the parent toolchain already is dummy, so I'll just drop them.
|
Test report by @boegel |
|
Test report by @boegel |
|
Thanks for the review @verdurin! |
(created using
eb --new-pr)