modloadmsg style fixes#4035
modloadmsg style fixes#4035boegel merged 4 commits intoeasybuilders:developfrom SethosII:modloadmsg-style-fixes
Conversation
they shouldn't be needed here
changed mutliple modloadmsg to one multiline modloadmsg added new lines at the end of modloadmsg changed triple quotes to single quotes for single line strings
boegel
left a comment
There was a problem hiding this comment.
Thanks a lot for looking into this!
Two minor style issues w.r.t. long lines, but otherwise looks good to go...
|
|
||
| modloadmsg = """For improved speed, add 'usejni=t' to the command line of %(name)s tools which support the use of the | ||
| compiled jni C code.""" | ||
| modloadmsg = "For improved speed, add 'usejni=t' to the command line of %(name)s tools which support the use of the compiled jni C code.\n" |
There was a problem hiding this comment.
@SethosII lines shouldn't go beyond 120 characters in length; if you want this to be a single line message, we should break it up like:
modloadmsg = "..."
modloadmsg += "...\n"same applies to the other BBMap easyconfigs
| # Be careful and have a message consistent with the generated wrappers | ||
| modloadmsg = "nvcc uses g++ as the default host compiler. If you want to use icpc as a host compiler you can use" | ||
| modloadmsg += " nvcc_icpc, or nvcc -ccbin=icpc. Likewise, a g++ wrapper called nvcc_g++ has been also created." | ||
| modloadmsg = "nvcc uses g++ as the default host compiler. If you want to use icpc as a host compiler you can use nvcc_icpc, or nvcc -ccbin=icpc. Likewise, a g++ wrapper called nvcc_g++ has been also created.\n" |
There was a problem hiding this comment.
@SethosII same here, this line is too long, please break it up using modloadmsg +=
|
Test report by @boegel |
|
@SethosII looks good to go, other than the two minor style issues |
|
I changed the long lines to use multiple modloadmsg. |
|
lgtm, will merge as soon as Travis gives green light, thanks @SethosII! |
|
Going in, thanks @SethosII! |
added new lines at the end of modloadmsg
changed mutliple modloadmsg to one multiline modloadmsg
changed triple quotes to single quotes for single line strings
removed curly braces for variables in modloadmsg
removed unnecessary escaping of $ in modloadmsg