fix source_urls for arpack-ng v3.1.3 and v3.1.5, ChIP-Seq v1.5-1, Ghostscript v9.10, v9.14 and v9.16, Git v1.7.12, v1.8.2 and v1.8.3.1, lynx v2.8.7 and MEME v4.8.0#4050
Conversation
| toolchain = {'name': 'goolf', 'version': '1.4.10'} | ||
|
|
||
| source_urls = ['http://downloads.sourceforge.net/project/chip-seq/chip-seq/%(version)s/'] | ||
| source_urls = ['http://downloads.sourceforge.net/project/chip-seq/chip-seq/1.5.1/'] |
There was a problem hiding this comment.
@migueldiascosta please avoid hardcoding stuff like this, since we're bound to miss this later
source_urls = ['http://downloads.sourceforge.net/project/chip-seq/chip-seq/%s/' % '.'.join(version.split('-'))]Any idea why we're using 1.5-1 as version? Is that a mistake?
There was a problem hiding this comment.
@boegel they seem to have changed scheme from e.g. 1.4-2 to e.g. 1.5.3, but in 1.5.0 and 1.5.1 they used the new scheme in the folder name and the old scheme in the filename...
|
@migueldiascosta since some of the download locations changed drastically, shall we also include checksums to make sure we're still downloading the same thing? |
|
@boegel some definitely changed, at least repackaged, I'll add the checksums of the current files |
| source_urls = ["http://downloads.ghostscript.com/public/old-gs-releases/"] | ||
| sources = [SOURCELOWER_TAR_GZ] | ||
|
|
||
| checksums = ['024f040b1371348a2b7fc4d25b379d33'] |
There was a problem hiding this comment.
this looks wrong, I'm getting 586494befb443363338c1b6379f13973 for this download...
Both when I try to redownload it, and with the download I had before:
$ ls -l ghostscript-9.14.tar.gz
-rw-rw-r-- 1 myuser myuser 35514406 Dec 10 2014 ghostscript-9.14.tar.gz
$ md5sum ghostscript-9.14.tar.gz
586494befb443363338c1b6379f13973 ghostscript-9.14.tar.gz
|
lgtm |
|
Going in, thanks @migueldiascosta! |
(created using
eb --new-pr)