Skip to content

remove incorrect definition for $ROSETTA3_DB, now (correctly) defined via Rosetta easyblock#4083

Merged
boegel merged 1 commit intoeasybuilders:developfrom
boegel:rosetta_db
Jan 31, 2017
Merged

remove incorrect definition for $ROSETTA3_DB, now (correctly) defined via Rosetta easyblock#4083
boegel merged 1 commit intoeasybuilders:developfrom
boegel:rosetta_db

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Jan 31, 2017

builddependencies = [('SCons', '2.3.6', '-Python-2.7.9')]

modextravars = {
'ROSETTA3_DB': '$root/database',
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the correct way would have been to use %(installdir)s/database, but it's better to do this in the existing Rosetta easyblock, cfr. easybuilders/easybuild-easyblocks#1092

@boegel boegel changed the title remove incorrect definition for $ROSETTA_DB, now (correctly) defined via Rosetta easyblock remove incorrect definition for $ROSETTA3_DB, now (correctly) defined via Rosetta easyblock Jan 31, 2017
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jan 31, 2017

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2304.phanpy.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/28d95ccb6da8705f9162462f86e93da3 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jan 31, 2017

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2039.delcatty.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/9fb16b0b194b35a58a362bf76f50e924 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jan 31, 2017

tested on top of easybuilders/easybuild-easyblocks#1092, trivial change so good to go

@boegel boegel merged commit d273e36 into easybuilders:develop Jan 31, 2017
@boegel boegel deleted the rosetta_db branch January 31, 2017 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant