Conversation
|
@migueldiascosta please review? |
|
Test report by @migueldiascosta |
| # Homepage: https://www.adelaide.edu.au/phoenix/ | ||
| # | ||
| # Copyright:: adelaide.edu.au/phoenix | ||
| # Authors:: Robert Qiao <[email protected]>, Exequiel Manuel Sepulveda Escobedo <[email protected]> |
There was a problem hiding this comment.
line too long (134 > 120 characters)
| toolchain = {'name': 'dummy', 'version': 'dummy'} | ||
|
|
||
| source_urls = ['http://www.icbi.at/software/meRanTK/downloads'] | ||
| sources = ['%s/meRanTK-%s.zip' %(version,version,)] |
There was a problem hiding this comment.
should be
source_urls = ['http://www.icbi.at/software/meRanTK/downloads/%(version)s/']
sources = ['meRanTK-%(version)s.zip']
| ] | ||
|
|
||
| sanity_check_paths = { | ||
| 'files':['bin/meRanAnnotate'], |
There was a problem hiding this comment.
use spaces for indentation instead of tabs, and should be a single files list, e.g.
'files': ['bin/meRan%s' % x for x in ['Annotate', 'Call', 'Compare', 'Gs', 'Gt', 'T']],
| sources = ['%s/meRanTK-%s.zip' %(version,version,)] | ||
|
|
||
| dependencies = [ | ||
| ] |
There was a problem hiding this comment.
if there are no dependencies, unnecessary?
| name = 'meRanTK' | ||
| version = '1.1.1b' | ||
|
|
||
| easyblock = 'BinariesTarball' |
There was a problem hiding this comment.
easyblock should be on top, above name =, and with an empty line in between
| 'files':['bin/meRanGs'], | ||
| 'files':['bin/meRanGt'], | ||
| 'files':['bin/meRanT'], | ||
| 'dirs':[], |
There was a problem hiding this comment.
'dirs': [], is still required (that's why Travis is failing), sorry if I wasn't clear
| 'files':['bin/meRanGt'], | ||
| 'files':['bin/meRanT'], | ||
| 'dirs':[], | ||
| 'files': ['bin/meRan%s' % x for x in ['Annotate', 'Call', 'Compare', 'Gs', 'Gt', 'T']], |
There was a problem hiding this comment.
Continuation line under-indented for hanging indent (needs 4 spaces instead of 1). With EasyBuild >= 3.1.0, you can use the --check-style option (easybuilders/easybuild-framework/pull/2038)
There was a problem hiding this comment.
This sounds very handy, thanks.
|
Test report by @boegel |
|
Thanks for the thorough review @migueldiascosta! |
|
Going in, thanks @robqiao! |
No description provided.