more style fixes in easyconfigs#4176
Conversation
|
@wpoely86 please review? |
| @@ -29,7 +28,7 @@ buildopts = ' STAR && make STARlong' | |||
| parallel = 1 | |||
|
|
|||
| files_to_copy = [(["source/STAR", "source/STARlong"], "bin"), "CHANGES.md", "doc", "extras", "LICENSE", "README.md", "RELEASEnotes.md"] | |||
There was a problem hiding this comment.
line too long (135 > 120 characters)
There was a problem hiding this comment.
Lines that are too long should be picked up by the tests?
There was a problem hiding this comment.
@wpoely86 The style tests are not enabled yet, we need to resolve over 1k style issues in the current easyconfigs collection before we can do that...
I'm gradually working towards making --style-check pass on all the easyconfigs we have now, with the intention to enable the style checks ASAP
There was a problem hiding this comment.
@boegel Okay, but please run them at least on all the once you change?
There was a problem hiding this comment.
Yeah, good point, I should
| @@ -29,7 +28,7 @@ buildopts = ' STAR && make STARlong' | |||
| parallel = 1 | |||
|
|
|||
| files_to_copy = [(["source/STAR", "source/STARlong"], "bin"), "CHANGES.md", "doc", "extras", "LICENSE", "README.md", "RELEASEnotes.md"] | |||
There was a problem hiding this comment.
line too long (135 > 120 characters)
| @@ -31,7 +30,7 @@ buildopts = ' STAR && make STARlong' | |||
| parallel = 1 | |||
|
|
|||
| files_to_copy = [(["source/STAR", "source/STARlong"], "bin"), "CHANGES.md", "doc", "extras", "LICENSE", "README.md", "RELEASEnotes.md"] | |||
There was a problem hiding this comment.
line too long (135 > 120 characters)
| @@ -29,7 +28,7 @@ buildopts = ' STAR && make STARlong' | |||
| parallel = 1 | |||
|
|
|||
| files_to_copy = [(["source/STAR", "source/STARlong"], "bin"), "CHANGES.md", "doc", "extras", "LICENSE", "README.md", "RELEASEnotes.md"] | |||
There was a problem hiding this comment.
line too long (135 > 120 characters)
| "LICENSE", | ||
| "README.md", | ||
| (["source/STAR", "source/STARlong"], "bin"), | ||
| "CHANGES.md", |
There was a problem hiding this comment.
continuation line unaligned for hanging indent
| "LICENSE", | ||
| "README.md", | ||
| (["source/STAR", "source/STARlong"], "bin"), | ||
| "CHANGES.md", |
There was a problem hiding this comment.
continuation line unaligned for hanging indent
| ('APR-util', '1.5.4'), | ||
| # ('OpenSSL', '1.0.1p'), # OS dependency should be preferred if the os version is more recent then this version, it's | ||
| # nice to have an up to date openssl for security reasons | ||
| # ('OpenSSL', '1.0.1p'), # OS dependency should be preferred if the os version is more recent then this version, it's |
There was a problem hiding this comment.
line too long (122 > 120 characters)
|
Thanks for the review @wpoely86 and @migueldiascosta! |
No description provided.