Skip to content

{devel}[*] CMake: Set CMAKE_PREFIX_PATH to ncurses install directory#4196

Merged
boegel merged 3 commits intoeasybuilders:developfrom
geimer:cmake_ncurses
Feb 25, 2017
Merged

{devel}[*] CMake: Set CMAKE_PREFIX_PATH to ncurses install directory#4196
boegel merged 3 commits intoeasybuilders:developfrom
geimer:cmake_ncurses

Conversation

@geimer
Copy link
Copy Markdown
Contributor

@geimer geimer commented Feb 23, 2017

Also, include ccmake in sanity check.

This fixes #4171 for 28 configurations (2016 toolchains). Fixing the remaining 64 configurations is left as an exercise for someone who wants to (re-)install CMake with older toolchains.

@geimer
Copy link
Copy Markdown
Contributor Author

geimer commented Feb 23, 2017

Test report by @geimer
SUCCESS
Build succeeded for 15 out of 15 (15 easyconfigs in this PR)
swatc03 - Linux debian 8.7, Six-Core AMD Opteron(tm) Processor 2427, Python 2.7.9
See https://gist.github.com/f7cb72fe2808deffde80f7901ffadf41 for a full test report.

@boegel boegel added this to the 3.2.0 milestone Feb 23, 2017
@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 23, 2017

lgtm, although I'd really prefer to make this change a bit more consistent, at least for say CMake 3.4.x and up or something like that...

@geimer
Copy link
Copy Markdown
Contributor Author

geimer commented Feb 24, 2017

@boegel Here you go - 11 more easyconfigs. Now CMake 3.4.0 and up should be covered.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 24, 2017

Thanks @geimer!

I'll look into a test report for this bunch...

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 25, 2017

Test report by @boegel
SUCCESS
Build succeeded for 37 out of 37 (37 easyconfigs in this PR)
node2104.delcatty.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/8bff2ae6e00ab68f16db8a7d824412a4 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 25, 2017

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 25, 2017

Going in, thanks @geimer!

@boegel boegel merged commit 4a2ab64 into easybuilders:develop Feb 25, 2017
@geimer geimer deleted the cmake_ncurses branch February 26, 2017 13:45
@boegel boegel modified the milestones: 3.2.0, 3.1.1 Feb 28, 2017
@boegel boegel mentioned this pull request Mar 3, 2017
Merged
@geimer geimer mentioned this pull request May 3, 2017
Closed
@boegel boegel mentioned this pull request May 31, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.1.1

Development

Successfully merging this pull request may close these issues.

2 participants

@geimer @boegel