Skip to content

fix version (& homepage) in ea-utils easyconfigs#4205

Merged
boegel merged 1 commit intoeasybuilders:developfrom
boegel:ea-utils
Feb 27, 2017
Merged

fix version (& homepage) in ea-utils easyconfigs#4205
boegel merged 1 commit intoeasybuilders:developfrom
boegel:ea-utils

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Feb 25, 2017

when looking into #4204, I noticed that ea-utils now available with a proper version on GitHub, so we don't need to use the commit as a version anymore...

Originally contributed by @RvDijk (#3634), and updatd by @verdurin (#3834), so feedback from the both of you would be great since this is a 'breaking' change.

As far as I can tell ea-utils is not used as a dependency somewhere else, so changing the version like we do here is acceptable imho (since it won't break other easyconfigs).

@boegel boegel added this to the 3.2.0 milestone Feb 25, 2017
@RvDijk
Copy link
Copy Markdown
Contributor

RvDijk commented Feb 25, 2017

@boegel looks good to me.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 26, 2017

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2304.phanpy.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/23d11508263d06ea044734f798af8e8e for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 26, 2017

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2097.delcatty.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/fe9061f8d301b8af9e9fef65052929d3 for a full test report.

Copy link
Copy Markdown
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth bumping the build deps for the 2016b version to Perl 5.24.0?

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 27, 2017

@verdurin we usually don't bump dependencies in existing easyconfigs... Also, this is just a build dependency?

@verdurin
Copy link
Copy Markdown
Member

It is, yes.

That being the case, looks fine to me.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 27, 2017

Thanks for the feedback @RvDijk and @verdurin!

@boegel boegel merged commit 5f4686b into easybuilders:develop Feb 27, 2017
@boegel boegel deleted the ea-utils branch February 27, 2017 12:21
@boegel boegel modified the milestones: 3.2.0, 3.1.1 Feb 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants