another batch of minor style fixes#4233
Conversation
|
@wpoely86, @migueldiascosta please review? |
|
|
||
| dependencies = [ | ||
| ('fftw/3.3.4.5', EXTERNAL_MODULE), | ||
| ('fftw/3.3.4.3', EXTERNAL_MODULE), |
There was a problem hiding this comment.
not just a style fix, was the change in version number intended?
There was a problem hiding this comment.
oh, nice catch, copy-paste error, will fix
| """ | ||
| description = """The OBITools programs aims to help you to manipulate various data and sequence files in a | ||
| convenient way using the Unix command line interface. They follow the standard Unix interface for command line | ||
| program, allowing to chain a set of commands using the pipe mecanism. """ |
There was a problem hiding this comment.
delete whitespace at end of last sentence?
| ] | ||
|
|
||
| configopts = '-DCMAKE_BUILD_TYPE=Release -DEIGEN3_ROOT=$EBROOTEIGEN -DCMAKE_CXX_FLAGS="$LIBLAPACK_MT -DEIGEN_USE_MKL_ALL"' | ||
| configopts = "-DCMAKE_BUILD_TYPE=Release -DEIGEN3_ROOT=$EBROOTEIGEN " |
There was a problem hiding this comment.
I tend to use double quotes for strings that include spaces, unless there's a technical reason not to (e.g. double quotes required in the string itself).
See WIP version of easyconfigs style guide at http://boegel-eb.readthedocs.io/en/easyconfigs_style/Code_style.html#code-style-easyconfigs-string-quotes
|
|
||
| buildopts = '-f Makefile.SSE3.PTHREADS.gcc CC="$CC" && mkdir -p %(installdir)s/bin && cp raxmlHPC-PTHREADS-SSE3 %(installdir)s/bin' | ||
| buildopts = '-f Makefile.SSE3.PTHREADS.gcc CC="$CC" && ' | ||
| buildopts += "mkdir -p %(installdir)s/bin && cp raxmlHPC-PTHREADS-SSE3 %(installdir)s/bin" |
There was a problem hiding this comment.
single<->double quotes on the last lines?
There was a problem hiding this comment.
same here: contains spaces, hence "
line above requires use of "..." to ensure bash expansion of $CC, so there I use single quotes for the string
|
Thanks for the thorough review @wpoely86 and @migueldiascosta! |
No description provided.