Skip to content

fix missing PYTHONPATH in ROOT v6.08.02 easyconfig#4239

Merged
boegel merged 2 commits intoeasybuilders:developfrom
ysagon:ROOT-6.08.02-pythonpath
Mar 10, 2017
Merged

fix missing PYTHONPATH in ROOT v6.08.02 easyconfig#4239
boegel merged 2 commits intoeasybuilders:developfrom
ysagon:ROOT-6.08.02-pythonpath

Conversation

@ysagon
Copy link
Copy Markdown
Contributor

@ysagon ysagon commented Mar 2, 2017

as ROOT compiles a ROOT.py module as well and put it in the lib folder, we need to set the PYTHONPATH as well.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 2, 2017

@ysagon We should make this change consistent across all ROOT easyconfigs where ROOT.py is available?

It seems that this got moved from /lib/root/ to /lib/ in a recent version of ROOT:

$ find software/ROOT -name ROOT.py
software/ROOT/v6.06.02-intel-2016b-Python-2.7.12/lib/root/ROOT.py
software/ROOT/v5.34.13-ictce-5.5.0/lib/root/ROOT.py
software/ROOT/v5.34.34-intel-2016a-Python-2.7.11/lib/root/ROOT.py
software/ROOT/v5.34.36-intel-2016a-Python-2.7.11/lib/root/ROOT.py
software/ROOT/v5.34.34-intel-2015b-Python-2.7.10/lib/root/ROOT.py
software/ROOT/v6.08.02-foss-2016a-Python-2.7.11/lib/ROOT.py

@boegel boegel added this to the 3.2.0 milestone Mar 2, 2017
@ysagon
Copy link
Copy Markdown
Contributor Author

ysagon commented Mar 6, 2017

@boegel I have no idea! And I even don't know how people where importing ROOT.py without the PYTHONPATH set? Maybe it's not the correct way?

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 6, 2017

@ysagon Well, maybe nobody was, or they were just updating $PYTHONPATH themselves after loading the ROOT module?

I see no other way to make the import work...

BTW, I think it makes sense to also add an additional sanity check command to verify that import ROOT works, as follows:

sanity_check_commands = ["python -c 'import ROOT'"]

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 6, 2017

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2151.delcatty.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/fb2e633319aed0ee75219fb43dd79fe1 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 6, 2017

@ysagon Looks good!

So, shall we apply this to all ROOT easyconfigs for consistency?

@ysagon
Copy link
Copy Markdown
Contributor Author

ysagon commented Mar 8, 2017

@boegel I think so. Do you want me to do it?

@boegel boegel changed the title fix missing PYTHONPATH fix missing PYTHONPATH in ROOT easyconfigs Mar 8, 2017
@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 8, 2017

@ysagon Yes, that would be nice, I can take care of submitting a test report.

ysagon added a commit to ysagon/easybuild-easyconfigs that referenced this pull request Mar 10, 2017
ysagon added a commit to ysagon/easybuild-easyconfigs that referenced this pull request Mar 10, 2017
ysagon added a commit to ysagon/easybuild-easyconfigs that referenced this pull request Mar 10, 2017
ysagon added a commit to ysagon/easybuild-easyconfigs that referenced this pull request Mar 10, 2017
ysagon added a commit to ysagon/easybuild-easyconfigs that referenced this pull request Mar 10, 2017
ysagon added a commit to ysagon/easybuild-easyconfigs that referenced this pull request Mar 10, 2017
ysagon added a commit to ysagon/easybuild-easyconfigs that referenced this pull request Mar 10, 2017
ysagon added a commit to ysagon/easybuild-easyconfigs that referenced this pull request Mar 10, 2017
ysagon added a commit to ysagon/easybuild-easyconfigs that referenced this pull request Mar 10, 2017
ysagon added a commit to ysagon/easybuild-easyconfigs that referenced this pull request Mar 10, 2017
ysagon added a commit to ysagon/easybuild-easyconfigs that referenced this pull request Mar 10, 2017
@ysagon ysagon mentioned this pull request Mar 10, 2017
@boegel boegel changed the title fix missing PYTHONPATH in ROOT easyconfigs fix missing PYTHONPATH in ROOT v6.08.02 easyconfig Mar 10, 2017
@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 10, 2017

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2569.golett.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/3eabcd7b0268208ab85f2cfd36c58e5e for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 10, 2017

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 10, 2017

Going in, thanks @ysagon!

@boegel boegel merged commit e31ae2d into easybuilders:develop Mar 10, 2017
@boegel boegel modified the milestones: 3.1.2, 3.2.0 Mar 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants