Skip to content

{bio}[intel/2016b] DBG2OLC v20170208#4281

Merged
boegel merged 2 commits intoeasybuilders:developfrom
boegel:20170308151815_new_pr_DBG2OLC20170208
Mar 8, 2017
Merged

{bio}[intel/2016b] DBG2OLC v20170208#4281
boegel merged 2 commits intoeasybuilders:developfrom
boegel:20170308151815_new_pr_DBG2OLC20170208

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Mar 8, 2017

(created using eb --new-pr)

@boegel boegel added this to the 3.1.2 milestone Mar 8, 2017
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 8, 2017

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2458.golett.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/d851d6fd7f621c3e99632b0d651fc872 for a full test report.

@wpoely86
Copy link
Copy Markdown
Member

wpoely86 commented Mar 8, 2017

Test report by @wpoely86
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
nic66 - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2680 v4 @ 2.40GHz, Python 2.7.5
See https://gist.github.com/3e56c9837e7d5a72ef9180f62511a266 for a full test report.

wpoely86
wpoely86 reviewed Mar 8, 2017
View reviewed changes
Comment thread easybuild/easyconfigs/d/DBG2OLC/DBG2OLC-20170208-intel-2016b.eb Outdated
source_urls = ['https://github.com/yechengxi/DBG2OLC/archive/']
sources = ['%s.tar.gz' % commit]

cmds_map = [('.*', "$CXX $CXXFLAGS -o DBG2OLC *.cpp")]
Copy link
Copy Markdown
Member

@wpoely86 wpoely86 Mar 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here you do need LDFLAGS 😉

Copy link
Copy Markdown
Member Author

@boegel boegel Mar 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? What is $LDFLAGS going to give me extra, build works fine?

Copy link
Copy Markdown
Member

@wpoely86 wpoely86 Mar 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it's the proper thing to do. If you compile directly from source to binary, you need both $CXXFLAGS and $LDFLAGS. It's not because it works now that it will do so in the future.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 8, 2017

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2141.delcatty.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/04b5d2c343efd8c63fe31a11d8411a59 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 8, 2017

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2141.delcatty.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/aa0b2e693864cb2ccdbfaaa3c9b81157 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 8, 2017

Thanks for the review @wpoely86!

@boegel boegel merged commit 5b8617a into easybuilders:develop Mar 8, 2017
@boegel boegel deleted the 20170308151815_new_pr_DBG2OLC20170208 branch March 8, 2017 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wpoely86 wpoely86 wpoely86 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.1.2

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @wpoely86