{bio}[foss/2016b] PileOMeth v0.1.11#4289
Conversation
| source_urls = ['https://github.com/dpryan79/PileOMeth/archive/'] | ||
|
|
||
| dependencies = [ | ||
| ('HTSlib', '1.2.1', '', ('foss', '2017a')) |
There was a problem hiding this comment.
@robqiao You should include an easyconfig for this dependency in this pull request (see failing tests in Travis), and use foss/2017a as toolchain rather than specifying the toolchain for the dependency, i.e.:
toolchain = {'name': 'foss', 'version': '2017a'}
...
dependencies = [
('HTSlib', '1.2.1'),
]There was a problem hiding this comment.
@boegel thanks. Is that a convention to use a tool chain option if any dependencies use one, even when parent itself not use any?
There was a problem hiding this comment.
Since PileOMeth is also being compiled, it's a lot better to specify the toolchain to something that is not dummy, since then EasyBuild will also set up the build environment (stuff like $CC, $CFLAGS, etc.)
The dependencies by default will inherit the parent toolchain. You can hard specify to use a particular toolchain on a per-dependency basis, but then these should be a subtoolchain of the parent toolchain. In practice, we only do this when a particular dependency was installed with a dummy toolchain (e.g. a binary tool that doesn't require compiling).
See also http://easybuild.readthedocs.io/en/latest/Writing_easyconfig_files.html#dependencies
| ] | ||
|
|
||
| files_to_copy = [ | ||
| (["PileOMeth"], "bin"), "*.c", "*.h" |
There was a problem hiding this comment.
@robqiao Any particular reason you are also copying the *.c and *.h files?
There was a problem hiding this comment.
@boegel some of our users use .h to build their own functions using existing functions, but I guess I should remove these for this purpose. :)
There was a problem hiding this comment.
Well, than you should only include the *.h files, and copy them to the include subdirectory (so that the location gets added to $CPATH)?
| ] | ||
|
|
||
| sanity_check_paths = { | ||
| 'files': ["bin/bgzip", "bin/tabix", "lib/libhts.so"], |
There was a problem hiding this comment.
please use 'lib/libhts.%s' % SHLIB_EXT rather than hardcoding the .so
There was a problem hiding this comment.
Thanks for the tip.
|
Test report by @boegel |
|
Test report by @boegel |
|
lgtm |
|
Going in, thanks @robqiao! |
New easyconfig file for PileOMeth added