Skip to content

{bio}[foss/2016b] PileOMeth v0.1.11#4289

Merged
boegel merged 4 commits intoeasybuilders:developfrom
manifestoso:addeasyconfigs
Mar 10, 2017
Merged

{bio}[foss/2016b] PileOMeth v0.1.11#4289
boegel merged 4 commits intoeasybuilders:developfrom
manifestoso:addeasyconfigs

Conversation

@manifestoso
Copy link
Copy Markdown
Contributor

New easyconfig file for PileOMeth added

source_urls = ['https://github.com/dpryan79/PileOMeth/archive/']

dependencies = [
('HTSlib', '1.2.1', '', ('foss', '2017a'))
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robqiao You should include an easyconfig for this dependency in this pull request (see failing tests in Travis), and use foss/2017a as toolchain rather than specifying the toolchain for the dependency, i.e.:

toolchain = {'name': 'foss', 'version': '2017a'}
...
dependencies = [
    ('HTSlib', '1.2.1'),
]

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel thanks. Is that a convention to use a tool chain option if any dependencies use one, even when parent itself not use any?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since PileOMeth is also being compiled, it's a lot better to specify the toolchain to something that is not dummy, since then EasyBuild will also set up the build environment (stuff like $CC, $CFLAGS, etc.)

The dependencies by default will inherit the parent toolchain. You can hard specify to use a particular toolchain on a per-dependency basis, but then these should be a subtoolchain of the parent toolchain. In practice, we only do this when a particular dependency was installed with a dummy toolchain (e.g. a binary tool that doesn't require compiling).

See also http://easybuild.readthedocs.io/en/latest/Writing_easyconfig_files.html#dependencies

]

files_to_copy = [
(["PileOMeth"], "bin"), "*.c", "*.h"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robqiao Any particular reason you are also copying the *.c and *.h files?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel some of our users use .h to build their own functions using existing functions, but I guess I should remove these for this purpose. :)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, than you should only include the *.h files, and copy them to the include subdirectory (so that the location gets added to $CPATH)?

@boegel boegel added this to the 3.2.0 milestone Mar 9, 2017
@boegel boegel changed the title PileOMeth added {bio}[foss/2016b] PileOMeth v0.1.11 Mar 10, 2017
]

sanity_check_paths = {
'files': ["bin/bgzip", "bin/tabix", "lib/libhts.so"],
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use 'lib/libhts.%s' % SHLIB_EXT rather than hardcoding the .so

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tip.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 10, 2017

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2054.delcatty.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/90cb683d6a9daddcefdfde14873099d6 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 10, 2017

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2569.golett.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/29c30e1e419749de34ff17833a24799c for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 10, 2017

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 10, 2017

Going in, thanks @robqiao!

@boegel boegel merged commit 97d4734 into easybuilders:develop Mar 10, 2017
@boegel boegel modified the milestones: 3.1.2, 3.2.0 Mar 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants