Skip to content

miRDeep2 scripts do a hard check for an (empty) file named 'install_successful' in the install dir...#4291

Merged
boegel merged 1 commit intoeasybuilders:developfrom
boegel:miRDeep2
Mar 9, 2017
Merged

miRDeep2 scripts do a hard check for an (empty) file named 'install_successful' in the install dir...#4291
boegel merged 1 commit intoeasybuilders:developfrom
boegel:miRDeep2

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Mar 9, 2017

No description provided.

@boegel boegel added this to the 3.1.2 milestone Mar 9, 2017
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 9, 2017

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2635.swalot.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/c27ab31e84554cc597742fb97da804c3 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 9, 2017

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
gligar02.gligar.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/39bf86928067b56250faf5fdc15e9c24 for a full test report.

wpoely86
wpoely86 reviewed Mar 9, 2017
View reviewed changes
Comment thread easybuild/easyconfigs/m/miRDeep2/miRDeep2-2.0.0.8-intel-2016b.eb
install_cmd += "touch %(installdir)s/install_successful"

sanity_check_paths = {
'files': ['bin/make_html.pl'],
Copy link
Copy Markdown
Member

@wpoely86 wpoely86 Mar 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is gone?

Copy link
Copy Markdown
Member Author

@boegel boegel Mar 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but it makes more sense to check the other scripts I'm checking now, which seem to be the main scripts.

There are a whole bunch more scripts in there, I don't think it makes sense to make the check much more exhaustive since this is basically a unpack&copy installation...

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 9, 2017

Thanks for the review @wpoely86!

@boegel boegel merged commit e06be9f into easybuilders:develop Mar 9, 2017
@boegel boegel deleted the miRDeep2 branch March 9, 2017 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wpoely86 wpoely86 wpoely86 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.1.2

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @wpoely86