Skip to content

correct bugs in dependency specifications and fix easyconfigs unit tests#431

Merged
boegel merged 6 commits intoeasybuilders:developfrom
boegel:module_naming_scheme
Sep 27, 2013
Merged

correct bugs in dependency specifications and fix easyconfigs unit tests#431
boegel merged 6 commits intoeasybuilders:developfrom
boegel:module_naming_scheme

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Sep 12, 2013

This PR resolves bugs in the dependency specifications in easyconfig files caused by an underspecified/ambiguous format (see easybuilders/easybuild-framework#686).

Dependency specifications in which the toolchain was glued to the version (or versionsuffix) is now done properly, e.g.:

('OpenMPI', '1.6.4', '', ('GCC', '4.7.2'))

instead of ( incorrect ):

('OpenMPI', '1.6.4-GCC-4.7.2')

or (also incorrect):

('OpenMPI', '1.6.4', '-GCC-4.7.2')

This depends on easybuilders/easybuild-framework#679.

@boegel boegel mentioned this pull request Sep 24, 2013
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use comp

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 27, 2013

Fixed remarks, so good to go.

boegel added a commit that referenced this pull request Sep 27, 2013
correct bugs in dependency specifications and fix easyconfigs unit tests
@boegel boegel merged commit 1363828 into easybuilders:develop Sep 27, 2013
@boegel boegel deleted the module_naming_scheme branch June 22, 2020 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants