rename S.A.G.E. to SAGE, can't have directories with trailing dot in Windows#4368
rename S.A.G.E. to SAGE, can't have directories with trailing dot in Windows#4368boegel merged 4 commits intoeasybuilders:developfrom
Conversation
|
Test report by @rjeschmi |
| source_urls = ['https://storage.googleapis.com/google-code-archive-downloads/v2/code.google.com/opensage/'] | ||
| sources = ['%(name)sv%(version)s_Linux_x86_64.tar.gz'] | ||
| source_urls = ['https://github.com/elstonsage/sageCore/releases/download/v6.3'] | ||
| sources = ['S.A.G.E.v%(version)s_Linux_x86_64.tar.gz'] |
There was a problem hiding this comment.
@rjeschmi let's include a checksum too, since we're changing the source_urls?
I have c94a0b9af656212251ce452f7b2f99ec for this one, both for old & new source_urls.
| toolchain = {'name': 'dummy', 'version': 'dummy'} | ||
|
|
||
| source_urls = ['http://darwin.cwru.edu/sage/files/'] | ||
| sources = ['S.A.G.E.v%(version)s_Linux_x86_64.tar.gz'] |
There was a problem hiding this comment.
please also add checksum: da3b135389df1ab9a21288cb041ac0c3
|
Test report by @rjeschmi |
|
|
||
| source_urls = ['https://storage.googleapis.com/google-code-archive-downloads/v2/code.google.com/opensage/'] | ||
| sources = ['%(name)sv%(version)s_Linux_x86_64.tar.gz'] | ||
| source_urls = ['https://github.com/elstonsage/sageCore/releases/download/v6.3'] |
There was a problem hiding this comment.
@rjeschmi one more detail: avoid hardcoding the version, use %(version)s:
source_urls = ['https://github.com/elstonsage/sageCore/releases/download/v%(version)s']|
lgtm |
|
Test report by @boegel |
|
Going in, thanks @rjeschmi! |
I'll also change the software name, but this generally works.