Skip to content

{bio}[dummy/] Sambamba v0.6.6#4442

Merged
boegel merged 2 commits intoeasybuilders:developfrom
pescobar:20170404131029_new_pr_Sambamba066
Apr 5, 2017
Merged

{bio}[dummy/] Sambamba v0.6.6#4442
boegel merged 2 commits intoeasybuilders:developfrom
pescobar:20170404131029_new_pr_Sambamba066

Conversation

@pescobar
Copy link
Copy Markdown
Member

@pescobar pescobar commented Apr 4, 2017

(created using eb --new-pr)

'PATH': "",
}

postinstallcmds = ['cd %(installdir)s && ln -s sambamba_v%(version)s sambamba',]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pescobar please move this up, above sanity_check_paths, and remove the trailing ,

sources = ['%(namelower)s_v%(version)s_linux.tar.bz2']

sanity_check_paths = {
'files': ['sambamba_v%(version)s'],
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also check for the symlink?

@boegel boegel added this to the 3.2.0 milestone Apr 4, 2017
@pescobar
Copy link
Copy Markdown
Member Author

pescobar commented Apr 5, 2017

@boegel once this is merged all the dependencies for #4444 should be available

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 5, 2017

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2156.delcatty.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/b38739fc8f78ff86aa92bb919d447152 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 5, 2017

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2524.golett.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/7bd9332f83388772fafe5f52a3b58601 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 5, 2017

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 5, 2017

Going in, thanks @pescobar!

@boegel boegel merged commit f1cb844 into easybuilders:develop Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants