{geo,math,numlib}[intel/2017a] StaMPS v3.3b1, snaphu v1.4.2, Triangle v1.6#4454
Conversation
….4.2-intel-2017a.eb, Triangle-1.6-intel-2017a.eb
|
@wpoely86 please review |
| buildopts = 'CC="$CXX" CFLAGS="$CXXFLAGS"' | ||
|
|
||
| preinstallopts = 'cp -a ../bin %(installdir)s/bin && ' | ||
| installopts = 'INSTALL_DIR=%(installdir)s/bin && cd .. && cp -a {DORIS_SCR,matlab,ROI_PAC_SCR} %(installdir)s/' |
There was a problem hiding this comment.
isn't this MakeCp? Is the make install needed?
There was a problem hiding this comment.
the make install copies stuff from different locations into $INSTALL_DIR, I don't see why we should replicate that via files_to_copy
it doesn't copy the _*SCR directories though, so that's done manually
|
|
||
| start_dir = 'src' | ||
|
|
||
| buildopts = 'CC="$CXX" CFLAGS="$CXXFLAGS"' |
|
|
||
| start_dir = 'src' | ||
|
|
||
| buildopts = 'CC="$CC" CFLAGS="$CFLAGS"' |
| sources = ['%(namelower)s.zip'] | ||
| checksums = [('md5', '10aff8d7950f5e0e2fb6dd2e340be2c9')] | ||
|
|
||
| patches = ['%(name)s-%(version)s_makefile.patch'] |
There was a problem hiding this comment.
patch is already there in develop
|
Test report by @boegel |
|
Test report by @boegel |
|
Thanks for the review @wpoely86! |
(created using
eb --new-pr)requires #4414