Skip to content

{lang,tools}[foss/2017a] Node-RED v0.16.2, nodejs v6.10.3#4542

Merged
boegel merged 4 commits intoeasybuilders:developfrom
boegel:20170503164731_new_pr_Node-RED0162
May 4, 2017
Merged

{lang,tools}[foss/2017a] Node-RED v0.16.2, nodejs v6.10.3#4542
boegel merged 4 commits intoeasybuilders:developfrom
boegel:20170503164731_new_pr_Node-RED0162

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented May 3, 2017

(created using eb --new-pr)

toolchain = {'name': 'foss', 'version': '2017a'}

source_urls = ['https://github.com/node-red/node-red/releases/download/%(version)s/']
sources = ['node-red-%(version)s.zip']
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

%(namelower)s ?

source_urls = ['http://nodejs.org/dist/v%(version)s/']
sources = ['node-v%(version)s.tar.gz']

allow_system_deps = [('Python', SYS_PYTHON_VERSION)]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why system?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it needs any Python as a build dependency, and we know there is one...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add that as a comment?

@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 3, 2017

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2123.delcatty.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/5bc04b23efe462297eb94e705a92b220 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 3, 2017

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2555.golett.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/5fb0ddffc1d7a77416bb316b84e7f5e4 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 4, 2017

Thanks for the review @wpoely86!

@boegel boegel merged commit 68f4024 into easybuilders:develop May 4, 2017
@boegel boegel deleted the 20170503164731_new_pr_Node-RED0162 branch May 4, 2017 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants