Skip to content

{phys}[intel/2017a] Siesta v4.0, Siesta v4.1-b2#4562

Merged
boegel merged 3 commits intoeasybuilders:developfrom
migueldiascosta:20170510072356_new_pr_Siesta40
May 10, 2017
Merged

{phys}[intel/2017a] Siesta v4.0, Siesta v4.1-b2#4562
boegel merged 3 commits intoeasybuilders:developfrom
migueldiascosta:20170510072356_new_pr_Siesta40

Conversation

@migueldiascosta
Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta commented May 9, 2017

(created using eb --new-pr)

@migueldiascosta
Copy link
Copy Markdown
Member Author

migueldiascosta commented May 10, 2017

Test report by @migueldiascosta
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
nscc04 - Linux RHEL 6.8, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz, Python 2.7.13
See https://gist.github.com/2291e27c3c265bf74a057875da7d7530 for a full test report.

@akesandgren
Copy link
Copy Markdown
Contributor

akesandgren commented May 10, 2017

These can be more generic.

vl = version.split('-')
source_urls = ['https://launchpad.net/siesta/%s/%%(version)s/+download' % vl[0]]
is better i think.

And a checksum to go with that perhaps?

@boegel boegel added this to the 3.2.1 milestone May 10, 2017
boegel
boegel reviewed May 10, 2017
View reviewed changes
Comment thread easybuild/easyconfigs/s/Siesta/Siesta-4.0-intel-2017a.eb Outdated

dependencies = [('netCDF-Fortran', '4.4.4')]

parallel = 1
Copy link
Copy Markdown
Member

@boegel boegel May 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@migueldiascosta This is no longer needed, right? It's handled by the easyblock?

boegel
boegel reviewed May 10, 2017
View reviewed changes
Comment thread easybuild/easyconfigs/s/Siesta/Siesta-4.1-b2-intel-2017a.eb Outdated

dependencies = [('netCDF-Fortran', '4.4.4')]

parallel = 1
Copy link
Copy Markdown
Member

@boegel boegel May 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

versions newer than 4.1 support building in parallel (according to the easyblock)?

@migueldiascosta
Copy link
Copy Markdown
Member Author

migueldiascosta commented May 10, 2017

Test report by @migueldiascosta
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
nscc04 - Linux RHEL 6.8, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz, Python 2.7.13
See https://gist.github.com/0b0fe5b40b7456cd3fbb985d02cfce33 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 10, 2017

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2053.delcatty.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/90c34cf0067f33785273d4aa99e565db for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 10, 2017

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2482.golett.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/cea95a6c7af2e7b7cd6030d52b1ceb02 for a full test report.

@migueldiascosta migueldiascosta mentioned this pull request May 10, 2017
Closed
@boegel
Copy link
Copy Markdown
Member

boegel commented May 10, 2017

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented May 10, 2017

Going in, thanks @migueldiascosta!

@boegel boegel merged commit 4a1b612 into easybuilders:develop May 10, 2017
@migueldiascosta migueldiascosta deleted the 20170510072356_new_pr_Siesta40 branch October 2, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.2.1

Development

Successfully merging this pull request may close these issues.

3 participants

@migueldiascosta @akesandgren @boegel