Skip to content

{tools}[intel/2017a] pyenchant v1.6.8, enchant v1.6.1, hunspell v1.6.1#4567

Merged
boegel merged 2 commits intoeasybuilders:developfrom
boegel:20170510153408_new_pr_pyenchant168
May 11, 2017
Merged

{tools}[intel/2017a] pyenchant v1.6.8, enchant v1.6.1, hunspell v1.6.1#4567
boegel merged 2 commits intoeasybuilders:developfrom
boegel:20170510153408_new_pr_pyenchant168

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented May 10, 2017

(created using eb --new-pr)

@boegel
adding easyconfigs: pyenchant-1.6.8-intel-2017a-Python-2.7.13.eb, enc…
f433280 
…hant-1.6.1-intel-2017a.eb, hunspell-1.6.1-intel-2017a.eb
@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 10, 2017

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2053.delcatty.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/b28f1ad232227a1d017fbc501a83cdf9 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 10, 2017

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2482.golett.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/80b92a8fb4b70803d58c2c4628797723 for a full test report.

@boegel boegel modified the milestone: 3.2.1 May 10, 2017
verdurin
verdurin reviewed May 10, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine except for the blank line minor comment.

Comment thread easybuild/easyconfigs/e/enchant/enchant-1.6.1-intel-2017a.eb
sources = [SOURCE_TAR_GZ]

builddependencies = [('Autotools', '20150215')]
dependencies = [('hunspell', '1.6.1')]
Copy link
Copy Markdown
Member

@verdurin verdurin May 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I prefer to have a blank line between the two different types of dependency...

@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 11, 2017

Thanks for the review @verdurin!

@boegel boegel merged commit 89cdcb0 into easybuilders:develop May 11, 2017
@boegel boegel deleted the 20170510153408_new_pr_pyenchant168 branch May 11, 2017 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@verdurin verdurin verdurin left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.2.1

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @verdurin