Skip to content

{bio}[intel/2017a] EricScript v0.5.5, ada v2.0-5, BWA v0.7.15, ...#4594

Merged
boegel merged 1 commit intoeasybuilders:developfrom
boegel:20170515171119_new_pr_EricScript055
May 16, 2017
Merged

{bio}[intel/2017a] EricScript v0.5.5, ada v2.0-5, BWA v0.7.15, ...#4594
boegel merged 1 commit intoeasybuilders:developfrom
boegel:20170515171119_new_pr_EricScript055

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented May 15, 2017

(created using eb --new-pr)

@boegel
adding easyconfigs: EricScript-0.5.5-intel-2017a-R-3.4.0.eb, ada-2.0-…
b1d528e 
…5-intel-2017a-R-3.4.0.eb, BWA-0.7.15-intel-2017a.eb, SAMtools-1.4.1-intel-2017a.eb, BEDTools-2.26.0-intel-2017a.eb, seqtk-1.2-intel-2017a.eb
@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 15, 2017

Test report by @boegel
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in this PR)
node2544.golett.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/1e37986f82c7f541895f37ad3096f694 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 15, 2017

Test report by @boegel
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in this PR)
node2084.delcatty.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/ab929434285f340c8068d8d95928b291 for a full test report.

@boegel boegel added this to the 3.3.0 milestone May 15, 2017
@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 15, 2017

@verdurin please review?

Only EricScript and ada are new, others are version/toolchain bumps

verdurin
verdurin reviewed May 16, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all look fine. Just occurred to me that it might be worth changing the older ones to meet the formatting of ada and EricScript? I suppose the differences are clearer when you see them together like this. E.g. modextrapaths

@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 16, 2017

@verdurin For tiny formatting differences like this, we really need automated checking for consistency, otherwise it's a constant back & forth...

Thanks for the review!

@boegel boegel merged commit 97e550d into easybuilders:develop May 16, 2017
@boegel boegel deleted the 20170515171119_new_pr_EricScript055 branch May 16, 2017 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@verdurin verdurin verdurin left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @verdurin