Skip to content

{bio}[intel/2017a] VariantMetaCaller 1.0#4632

Merged
boegel merged 2 commits intoeasybuilders:developfrom
boegel:VariantMetaCaller
May 24, 2017
Merged

{bio}[intel/2017a] VariantMetaCaller 1.0#4632
boegel merged 2 commits intoeasybuilders:developfrom
boegel:VariantMetaCaller

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented May 24, 2017

No description provided.

@boegel boegel added this to the 3.3.0 milestone May 24, 2017
@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 24, 2017

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2677.swalot.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/fe98d9a7b0b804f41d30648d6254e3c9 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 24, 2017

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2003.delcatty.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/a50c50fb94676962fe2038ceb14bf61b for a full test report.

wpoely86
wpoely86 reviewed May 24, 2017
View reviewed changes
Comment thread easybuild/easyconfigs/v/VariantMetaCaller/VariantMetaCaller-1.0_fix-hardcoding.patch Outdated
@echo 'Building target: $@'
@echo 'Invoking: GCC C++ Linker'
- g++ -o"VariantMetaCaller" $(OBJS) $(USER_OBJS) $(LIBS) -fopenmp
+ ${CXX} ${CXXFLAGS} -o"VariantMetaCaller" $(OBJS) $(USER_OBJS) $(LIBS) -fopenmp
Copy link
Copy Markdown
Member

@wpoely86 wpoely86 May 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LDFLAGS ?

Copy link
Copy Markdown
Member

@wpoely86 wpoely86 May 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't -fopenmp come from EB?

Copy link
Copy Markdown
Member Author

@boegel boegel May 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the point, there are no dependencies?

Copy link
Copy Markdown
Member

@wpoely86 wpoely86 May 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's the proper way of doing it. Why have LIBS ?

@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 24, 2017

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2677.swalot.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/5318d97de8456f89be5e98e26703c22c for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 24, 2017

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2003.delcatty.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/fa80f7dd00dabe0a123176ed45f105bc for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 24, 2017

Thanks for the review @wpoely86!

@boegel boegel merged commit f63bc21 into easybuilders:develop May 24, 2017
@boegel boegel deleted the VariantMetaCaller branch May 24, 2017 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wpoely86 wpoely86 wpoely86 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @wpoely86