Skip to content

{bio}[foss/2016b] CNVnator 0.3.3#4649

Merged
boegel merged 4 commits intoeasybuilders:developfrom
manifestoso:addeasyconfigs
May 31, 2017
Merged

{bio}[foss/2016b] CNVnator 0.3.3#4649
boegel merged 4 commits intoeasybuilders:developfrom
manifestoso:addeasyconfigs

Conversation

@manifestoso
Copy link
Copy Markdown
Contributor

@manifestoso manifestoso commented May 31, 2017

CNVnator easyconfig added

boegel
boegel requested changes May 31, 2017
View reviewed changes
Comment thread easybuild/easyconfigs/c/CNVnator/CNVnator-0.3.3-foss-2016b.eb
('Perl', '5.24.0'),
]

skipsteps = ['build']
Copy link
Copy Markdown
Member

@boegel boegel May 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, it's kind of strange to use MakeCp together with skipping the build step...

Maybe you want BinariesTarball instead? Cfr. http://easybuild.readthedocs.io/en/latest/version-specific/generic_easyblocks.html#binariestarball

Copy link
Copy Markdown
Contributor Author

@manifestoso manifestoso May 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel Hmm, there are many other files inside the .zip like src, license etc. a perl script is really what is needed here.

Copy link
Copy Markdown
Member

@boegel boegel May 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, I guess CmdCp is a better match, see http://easybuild.readthedocs.io/en/latest/version-specific/generic_easyblocks.html#cmdcp .

You'll still need skipsteps = ['build'], but it makes more sense to use CmdCp than MakeCp imho.

Copy link
Copy Markdown
Contributor Author

@manifestoso manifestoso May 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel sounds good to me. Thx

@boegel boegel added this to the 3.3.0 milestone May 31, 2017
@boegel boegel changed the title CNVnator added {bio}[foss/2016b] CNVnator 0.3.3 May 31, 2017
@boegel
Copy link
Copy Markdown
Member

boegel commented May 31, 2017

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented May 31, 2017

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2689.swalot.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/83961e267200c51f8427a01a2ae8843c for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 31, 2017

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2135.delcatty.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/9da66b82435a26441a1e547f03bd8f37 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 31, 2017

Going in, thanks @robqiao!

@boegel boegel merged commit 90be1e8 into easybuilders:develop May 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@manifestoso @boegel