Skip to content

avoid use of 'import' in BFAST easyconfigs, just strip of 'a' from version#4764

Merged
boegel merged 2 commits intoeasybuilders:developfrom
boegel:BFAST_no_import
Jun 21, 2017
Merged

avoid use of 'import' in BFAST easyconfigs, just strip of 'a' from version#4764
boegel merged 2 commits intoeasybuilders:developfrom
boegel:BFAST_no_import

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Jun 21, 2017

No description provided.

@boegel boegel added this to the 3.3.0 milestone Jun 21, 2017
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 21, 2017

@vanzod please review?

It's less generic, but certainly better than having an import statement in there imho...

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 21, 2017

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2156.delcatty.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/fc80849d3b6ca8c5bf64f14878eb3b1b for a full test report.

vanzod
vanzod reviewed Jun 21, 2017
View reviewed changes
Comment thread easybuild/easyconfigs/b/BFAST/BFAST-0.7.0a-goolf-1.4.10.eb Outdated
import string
swdir = version.rstrip(string.lowercase + string.uppercase)
# eg. http://sourceforge.net/projects/bfast/files/bfast/0.7.0/bfast-0.7.0a.tar.gz/download
source_urls = ['http://sourceforge.net/projects/bfast/files/bfast/%s/' % version.rstrip('a'), 'download']
Copy link
Copy Markdown
Member

@vanzod vanzod Jun 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An alternative closer to the original which does not involve user intervention:

swdir = ''.join(char for char in version if not char.isalpha())
source_urls = ['http://sourceforge.net/projects/bfast/files/bfast/%s/' % swdir, 'download']

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 21, 2017

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2156.delcatty.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/57eb59126fc9d75aabd9d433011f3fb9 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 21, 2017

Thanks for the review @vanzod!

@boegel boegel merged commit 8f0c3cd into easybuilders:develop Jun 21, 2017
@boegel boegel deleted the BFAST_no_import branch June 21, 2017 21:10
@boegel boegel mentioned this pull request Jun 21, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vanzod vanzod vanzod left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @vanzod